Solved I'm making a plugin, I need some help.

Hello. My friend gave me some code to compile for a plugin (stop players from spawning God apples from creative inv) But it don't seem to work.​

Code:java

package com.dcsoft;
import org.bukkit.Material;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.ItemSpawnEvent;
import org.bukkit.plugin.java.JavaPlugin;
public class GodApple extends JavaPlugin implements Listener{
public void onEnable() {
getServer().getPluginManager().registerEvents(this, this);
}
public void onDisable() {
}
@EventHandler
public void onSpawnItem(ItemSpawnEvent event) {
if(event.getEntity().getItemStack().getType()== Material.GOLDEN_APPLE) {
event.setCancelled(true);
}}
 

Is it something to do with that code?​

Thanks.​

 

You're listening to the wrong event. You want to listen to
http://jd.bukkit.org/rb/doxygen/da/...t_1_1inventory_1_1InventoryCreativeEvent.html

 

I think that's the wrong event... I'm not too sure about that tho...
EDIT: Is it just me...?
EDIT: Removed before people get mad

 

Jatoc
Ivan
Thanks, I'll give this a try.

Jatoc
I'm new to Java, I've made this change now Eclipse is giving me an error
(Screen shot) #1 http://prntscr.com/1and92 #2 http://prntscr.com/1andba

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

thomasb454

You can't just replace events like that. I already linked you to the javadocs describing/explaining all the different methods you can call for the event.

 

Jatoc

I read through them and tried some I thought would work. But they don't.
EDIT: lol Ivan
Maybe you could help me?

Code:java

 public void onSpawnItem(org.bukkit.event.inventory.InventoryCreativeEvent event) {
if(event.getCursor().getType()== Material.GOLDEN_APPLE) {
event.setCancelled(true);

 

You're checking for the current item on the cursor. I think you'll have to use .getSlot() to get the ID of the slot, and you'll have to use event.getInventory().getItem(slotid) to find the right itemstack

 

Ivan
Ok, I'll go test this.

Hay Ivan

Since I'm a noob, I don't know what to do :/

So, could you write that code for me?
Sorry If I seem lazy, but I don't understand Java, yet.

package com.dcsoft;

import org.bukkit.Material;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.ItemSpawnEvent;
import org.bukkit.plugin.java.JavaPlugin;

public class GodApple extends JavaPlugin implements Listener{

public void onEnable() {
getServer().getPluginManager().registerEvents(this, this);
}

public void onDisable() {

}

@EventHandler
public void onSpawnItem(org.bukkit.event.inventory.InventoryCreativeEvent event) {
if(event.getSlot().getItem()== Material.GOLDEN_APPLE) {
event.setCancelled(true);
}
}

}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I think its something around these lines:
if(event.getInventory().getItem(event.getSlot()).getType == Material.GOLDEN_APPLE)
//do ur shit but you'll have to add null checks etc.

 

Ivan
I'll give this a go. Thanks

Ivan
Nope, still don't work.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Weird... very weird...

 

:/

Can anyone else think of a solution?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

thomasb454 I hate saying this to people as only a few months ago was I also very new to Java but before attempting plugins this really is worth a look: http://wiki.bukkit.org/Plugin_Tutorial

It will help you a lot.

As for the actual question I thought Ivan's solution would work. Obviously not. Mind posting the whole code after adding those changes? Also you dont need

org.bukkit.event.inventory.InventoryCreativeEvent

you can just put

InventoryCreativeEvent

and then import it.

 

Hello Ad237

Code:java

package com.dcsoft;
 
import org.bukkit.Material;
import org.bukkit.event.inventory.InventoryCreativeEvent;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.ItemSpawnEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class GodApple extends JavaPlugin implements Listener{
 
public void onEnable() {
  getServer().getPluginManager().registerEvents(this, this);
}
 
public void onDisable() {
 
}
 
@EventHandler
public void onSpawnItem(InventoryCreativeEvent event) {
if(event.getInventory().getItem(event.getSlot()).getType() == Material.GOLDEN_APPLE)
  event.setCancelled(true);
  }
}
 
 
 
 
 

 

thomasb454
Don't you just import it?

EDIT: nevermind

 

Anyone have any ideas?

 

thomasb454 maybe try checking if the inventory contains it. Not just the slots.

 

wizzinangel
Hi, I want players to obtain GoldenApple via the in-game shop, not by spawning them in. So, this wouldn't work
I don't know if you can scan per item name? Because the Apples (from the shop) are renamed.

I really need this to work guys, please help!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

thomasb454 This stops them from adding the apple to their inventory:

Code:java

 
    @EventHandler
    public void onSpawnItem(InventoryCreativeEvent event) {
        ItemStack EGApple = new ItemStack(322,1, (byte)1);
        if (event.getInventory().contains(Material.getMaterial(322))) {
            event.setCancelled(true);
        }
        if (event.getInventory().contains(EGApple)) {
            event.setCancelled(true);
        }
    }
 

Hope that helps

 

wizzinangel
Thanks for this! But I get one error.
http://prntscr.com/1b0fmk

Dammit he went offline. :/

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I'll try and help you give 1 min tho

 

historio Ok, thanks!

 

Try

Code:java

@EventHandler
public void onSpawnItem(InventoryCreativeEvent event) {
Player player = event.getPlayer();
ItemStack EGApple = new ItemStack(322,1, (byte)1);
if (player.getInventory().contains(Material.getMaterial(322))) {
event.setCancelled(true);
}
if (player.getInventory().contains(EGApple)) {
event.setCancelled(true);
}

 

historio
2 errors now: http://prntscr.com/1b0sll
http://prntscr.com/1b0sog

 

Maybe you need to cast it?

 

I'm looking in to it

Code:java

@EventHandler
public void onSpawnItem(InventoryCreativeEvent event) {

Won't work for me?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

historio
Imported it?

 

thomasb454
Yes

 

historio
What error does it give?

 

I have to go now i'll try and help tomorrow

thomasb454
Sorry for leaving i will try and help tomorrow if this thing is not fixed