getkiller Skeleton

Hi guys why this not working ?

Code:java

 
String player = event.getEntity().getPlayer().getName();
Player playerInstance = (Player) event.getEntity();
EntityDamageEvent damageEvent = playerInstance.getLastDamageCause();
if(!(damageEvent instanceof EntityDamageByEntityEvent))
return;
Entity damager = ((EntityDamageByEntityEvent)damageEvent).getDamager();
 
if(damager instanceof Skeleton){
event.setDeathMessage("[NOTICE]" + ChatColor.RED + "[" + player + "]"
+ ChatColor.WHITE + " killed by skeleton ");
}
 

 

You should really use a listener if you want to catch events like the 'EntityDamageByEntityEvent'.
Here's the wiki's page about Listeners: http://wiki.bukkit.org/Event_API_Reference .

 

Mother__ Define "not working".

EDIT: What's with your first line? "getEntity().getPlayer()"?

 

when i die by skeleton not show message killed by skeleton

 

Mother__ Do you get any errors? Is your Listener registered? Does it even compile?

 

evilmidget38 not have error but not working with others monsters working but skeleton nothing

 

Mother__ Can you post all your code?

 

Code:java

 
String player = event.getEntity().getPlayer().getName();
 
Player playerInstance = (Player) event.getEntity();
EntityDamageEvent damageEvent = playerInstance.getLastDamageCause();
if(!(damageEvent instanceof EntityDamageByEntityEvent))
   return;
Entity damager = ((EntityDamageByEntityEvent)damageEvent).getDamager();
if(damager instanceof Spider){
event.setDeathMessage("[NOTICE]" + ChatColor.RED + "[" + player + "]"
+ ChatColor.WHITE + " killed by Spider");
}
if(damager instanceof Zombie){
event.setDeathMessage("[NOTICE]" + ChatColor.RED + "[" + player + "]"
+ ChatColor.WHITE + " killed by Zombie");
}
if(damager instanceof Skeleton){
event.setDeathMessage("[NOTICE]" + ChatColor.RED + "[" + player + "]"
+ ChatColor.WHITE + " killed by Skeleton");
}
if(damager instanceof Creeper){
event.setDeathMessage("[NOTICE]" + ChatColor.RED + "[" + player + "]"
+ ChatColor.WHITE + " killed by Creeper");
}
 
 
 

 

Mother__ What event is that, and how are you invoking getPlayer on an entity? That doesn't make sense.

 

i learn API bukkit please if u can help me

 

Mother__ Please answer my question. I can't help you if I don't know what you're doing. Additionally, you can't help yourself if you don't know what you're doing. If you're not familiar with java or bukkit, there are plenty of resources available to help you learn. If you're not using an IDE, I suggest you start doing so.

 

Use arrow instead of skeleton, then cast to an arrow, find the shooter then cast to player, or skeleton.

In more detail:

A skeleton is not actually killing you, the entity "Arrow" is. But an arrow can be shot by more than one thing, Shooters could be an entity such as a skeleton or a player (or any other mob with a bow), or it could be a block such as a dispenser.

So check for an arrow first (using instanceof) , if it is an arrow create a new variable of type arrow, get the shooter (in an entity form) then use instanceof for either skeleton or player.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Could me example ? thanks

 

The idea is to learn, not to just copy code. I told you what you needed to do.

Take your already existing code, change the "instanceof Skeleton" to arrow create a variable of Arrow called arrow with the data damager. Then create a new entity called killershooter with arrow.getShooter(), then use another "instanceof Skeleton"(or player) on killershooter.

 

@Craftii4 thx working code if someone want

Code:java

 
 
Arrow arrow = (Arrow) damager;
Entity killershooter = arrow.getShooter();
if(killershooter instanceof Skeleton) {
event.setDeathMessage("[NOTICE]" + ChatColor.RED + "[" + player + "]"
+ ChatColor.WHITE + " killed by skeleton ");
}
 

but have conflict when the player and killed by another player like this

Code:java

 
 
 
if (playerInstance.getKiller() instanceof Player){
event.setDeathMessage("[NOTICE]" + ChatColor.RED + "[" + player + "]"
+ ChatColor.WHITE + " killed by " + player.getKiller().getDisplayName() + " skeleton ");
}
 

Can help me please?

 

You're casting arrow to damager before checking if it's an arrow...