[SOLVED] :Get position of a specified player onCommand? Not working.

I'm implementing this into my code, so I don't want to post waht I have already. I know the basic imports.


So it should be something like:

Code:java

 
package obbystrength;
 
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
import obbystrength.obbystrength;
import org.bukkit.Bukkit;
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityExplodeEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class posget {
 
public boolean onCommand( CommandSender sender, Command cmd, String label,String[] args )
{
Player s = (Player)sender;
if (cmd.getName().equalsIgnoreCase("posget"))
{
if (args.length == 1) // If the length is zero, there are no arguments...
{
String argument = args[0];
Player player2 = Bukkit.getPlayer( argument );
if( player2 != null && player2.isOnline() )
return true;
}
        s.sendMessage(ChatColor.RED + "Coords: " + getLocation());
}
}
}
 
}
[syntax][/syntax]

 

s.sendMessage(ChatColor.RED + "Coords: " + player2.getLocation().toString());

Try it. If it wont work, try player2.getLocation() only.

Also you can't return true before you are done, execution will stop at return true. Also, when using the && operator, you need to enclose each part where you explicitly does not check for a boolean, in parenthesis. So do this:

1. if( (player2 != null) && player2.isOnline() ) {
2. s.sendMessage(ChatColor.RED + "Coords: " + player2.getLocation());
3. return true;
4. }
5. else
6. {
7. s.sendMessage(ChatColor.RED + "Cannot find player " + argument + ".");
8. return true; //Return true despite of error, since we have already informed player of error
9. }

 

I suggest using

s.sendMessage(ChatColor.RED + "Coords: " + player2.getLocation().getBlock().getLocation());

or something like that. (not on my coding computer so I don't know)

What this does is return the block coordinates of the player. The benefit of this is because just returning the players location will return a long ugly double, whereas blocks have integer coordinates.

 

How do you register this in the plugin.yml?
Iron_Crystal

I have:

Code:

  posget [args[0]:
    description: der7p
    usage: /<command>
    default: true

Hm...I changed my plugin.yml to:

Code:

  posget:
    description: der7p
    usage: /posget <user>
    default: true

But it won't let me do /posget <playername>

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

It's not working because you are returning before the sendMessage() can be executed. Move it in front of the return statement like this:

Code:

if( player2 != null && player2.isOnline() ) {
s.sendMessage(ChatColor.RED + "Coords: " + getLocation());
return true;
}

 

Nothing is executing now. No errors, no "invalid command" but nothing.

I now have:

Code:java

 
package obbystrength;
 
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
import obbystrength.obbystrength;
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityExplodeEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class posget {
 
public boolean onCommand( CommandSender sender, Command cmd, String label,String[] args )
{
Player s = (Player)sender;
if (cmd.getName().equalsIgnoreCase("posget"))
{
if (args.length == 1) // If the length is zero, there are no arguments...
{
String argument = args[0];
Player player2 = Bukkit.getPlayer( argument );
if( player2 != null && player2.isOnline() ) {
s.sendMessage(ChatColor.RED + "Coords: " + player2.getLocation().getBlock().getLocation());
return true;
}
}
}
return true;
}
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

posget is not implementing CommandExecutor. As this is not the case I'll bet you didn't assign it to the command in onEnable().

 

ZeusAllMighty11
In your main class, did you create a new instance of your command executor in onEnable()?

Code:

private posget pg;
 
pg = new posget(this);
getCommand("posget").setExecutor(pg);

 

r0306 That would tell him that pg isn't a CommandExecutor, so no, he didn't.
Also no need to save a reference to posget, so your code can be reduced to
getCommand("posget").setExecutor(new posget(this));

 

Thank you! And thanks above too ^^
testing if it works with others, then I will mark as solved571