Vault problem

So im making a GUI and in this gui an item will display the players balance. Im using Vault and Essentials econ to do this. this is my code

Code:

ItemStack Armor1 = new ItemStack(Material.GOLD_INGOT);
    ItemMeta Armorm1 = Armor1.getItemMeta();
    Armorm1.setDisplayName(ChatColor.GREEN + "Money Balance");
    ArrayList<String> ArmorA1 = new ArrayList<String>();
    ArmorA1.add(ChatColor.GRAY + "Your money balance is: " + ChatColor.DARK_AQUA + iKits.econ.getBalance(player));
    Armorm1.setLore(ArmorA1);
    Armor1.setItemMeta(Armorm1);
    bShop.setItem(8, Armor1);

So when they open the gui the item displays the players balance but if someone else lets say player 2 opens the gui both players will see players2s balance so is there any way to make this not happen so only the player that open see his own balance and not any one else? BTW player is the sender. Thanks!

 

Moved to plugin dev.

 

bump

 

therandy123 Firstly, only bump every 12 hours, secondly, you can store their value and name in a hashmap, then retrieve it for when they open the GUI. Therefore everyone has their own data.

 

Niknea So should I use UUID for this?

 

therandy123 I don't believe that's required using the Vault API, as vault will do that part for you, just store their username, and their balance.

 

Niknea How do i store the balance?

 

therandy123 In a HashMap, such as this one:

PHP:

    HashMap<String, Double> balances = new HashMap<String, Double>();

 

Niknea So i did bal.put(player.getName(), econ.getBalance(player));
and then what do i need to set the balance on the item to their balance using this?

 

therandy123 You'd get the player from the HashMap, like in the following code:

PHP:

meta.setDisplayName(balances.get(p.getName()));

 

Niknea It works but the problem is still there when another person opens the inventory the balance changes for both tha players my code:

Code:java

ItemStack bala = new ItemStack(Material.GOLD_INGOT);
    ItemMeta balmeta = bala.getItemMeta();
    balmeta.setDisplayName(ChatColor.GREEN + "Money balance");
    bala.addUnsafeEnchantment(Enchantment.DAMAGE_ALL, 1);
    HashMap<String, Double> balances = new HashMap<String, Double>();
    balances.put(player.getName(), iKits.econ.getBalance(player));
    ArrayList<String> ballore = new ArrayList<String>();
    ballore.add(ChatColor.GRAY + "Balance: " + balances.get(player.getName()));
    balmeta.setLore(ballore);
    bala.setItemMeta(balmeta);
 
        bShop.setItem(8, bala);

Do i have to check if the player cntains the map?

 

therandy123 Show us the creation of the Inventory and where you open it (full code would be preferred)

 

therandy123 I know the reason why it's happening, the ItemMeta displayname keeps changing as players open the Inventory, changing to different balances. However I currently don't know a fix to it, let me think on it, and I'll get back to you. Maybe xTigerRebornx knows?

 

Niknea Problem is that he uses the same Inventory for everyone (I believe, unable to tell without full code), so that when someone else opens it, the change occurs for that Inventory, which all Players view. Solution would be to create the Inventory dynamically (such that each Player has their own and the Inventory could be stored in a Map<UUID, Inventory>), and use those individual Inventories rather then a global Inventory

 

xTigerRebornx

Code:java

public class bShop implements Listener, CommandExecutor{
    public static Inventory bShop = Bukkit.createInventory(null, 9,  ChatColor.GREEN.toString() + ChatColor.BOLD + "bShop");
    public static Inventory bArmor = Bukkit.createInventory(null, 9,  ChatColor.GREEN.toString() + ChatColor.BOLD + "Armor");
    public static Inventory bHG = Bukkit.createInventory(null, 9,  ChatColor.GREEN.toString() + ChatColor.BOLD + "bShop HG");
    public static Inventory bArmorHG = Bukkit.createInventory(null, 9,  ChatColor.GREEN.toString() + ChatColor.BOLD + "Armor HG");
    public iKits plugin;
    public bShop(iKits instance){
        plugin = instance;
    }
        public boolean onCommand (CommandSender sender, Command cmd, String commandLabel, String[] args) {
 
            Player player = (Player) sender;
            if(!(plugin.hg.contains(player.getName()))) {
                player.sendMessage("tfrc");
                player.openInventory(bShop);
 
 
 
    ItemStack bala = new ItemStack(Material.GOLD_INGOT);
    ItemMeta balmeta = bala.getItemMeta();
    balmeta.setDisplayName(ChatColor.GREEN + "Money balance");
    bala.addUnsafeEnchantment(Enchantment.DAMAGE_ALL, 1);
    HashMap<String, Double> balances = new HashMap<String, Double>();
    balances.put(player.getName(), iKits.econ.getBalance(player));
    ArrayList<String> ballore = new ArrayList<String>();
    ballore.add(ChatColor.GRAY + "Balance: " + balances.get(player.getName()));
    balmeta.setLore(ballore);
    bala.setItemMeta(balmeta);
 
        bShop.setItem(8, bala);

This is my code right now

 

therandy123 See my comment above yours on how to fix your problem. You use one Inventory, meaning once someone else open's it, the items are shown to everyone.

 

xTigerRebornx I did like this not sure if it right

Code:java

static Player p;
    HashMap<UUID, Inventory> inv = new HashMap<UUID, Inventory>();
    public static Inventory bShop = Bukkit.createInventory(p, 9,  ChatColor.GREEN.toString() + ChatColor.BOLD + "bShop");
 
    public static Inventory bArmor = Bukkit.createInventory(p, 9,  ChatColor.GREEN.toString() + ChatColor.BOLD + "Armor");
    public static Inventory bHG = Bukkit.createInventory(p, 9,  ChatColor.GREEN.toString() + ChatColor.BOLD + "bShop HG");
    public static Inventory bArmorHG = Bukkit.createInventory(p, 9,  ChatColor.GREEN.toString() + ChatColor.BOLD + "Armor HG");
 
    public iKits plugin;
    public bShop(iKits instance){
 
        plugin = instance;
 
    }
        public boolean onCommand (CommandSender sender, Command cmd, String commandLabel, String[] args) {
 
            Player player = (Player) sender;
            p = (Player) sender;
            if(!(plugin.hg.contains(player.getName()))) {
                player.sendMessage("tfrc");
                player.openInventory(bShop);
                inv.put(p.getUniqueId(), bShop);
 

Im not the best at this

 

therandy123 You are still using the same Inventory for everyone. The idea is that each Player gets their own Inventory, so that the changes are only shown to them.

 

xTigerRebornx So should i use the hashmap to set the inventory for the player

 

therandy123 The Map would be used as a way to pair the Inventory with the Player. Something like:

Code:

Map<UUID, Inventory> inventories = (...);
 
// When accessing
Player p = (...);
if(inventory.get(p.getUniqueId()) != null){
// Inventory exists, you can grab it and use it
} else {
// Inventory doesn't exist, you need to make a new one and put it in.
}

Please note, this is pseudo-code, may/may not work. Its to show a concept, not to be taken word-by-word and copy pasted.
The concept with this is that each Player has their own Inventory that you set their individual balances in.