Two problems

So here is my first problem.

Code:java

 
            if(p.getInventory().getItemInHand().getItemMeta().hasLore())
            {
 
            }
            else
            {
                List<String>lore = new ArrayList<String>();
                lore.add(colorize(plugin.getConfig().getString("pickblockbreak")) + "1");
 
                p.getInventory().getItemInHand().getItemMeta().setLore(lore);
                p.updateInventory();
            }
 

Ive tested to see if this code ran, and it did. What seems to be the problem? I've tried make an ItemStack out of their iteminhand and resetting their item in hand to it, but that also didn't work.

Second problem, this one gives me a stack trace on this line

Code:java

 
                        if(p.getInventory().getItemInHand().getItemMeta().getLore().contains(ChatColor.GRAY + "Infinite I") && p.hasPermission("prisonprofessional.enchantments.infinite") && p.getInventory().getItemInHand().getType() != null && p.getInventory().getItemInHand().getType() != Material.AIR && p.hasPermission("prisonprofessional.enchantments.infinite.level.1"))
                        {
 
                        }
                        else
                        {
                            p.getInventory().getItemInHand().setDurability((short) (p.getInventory().getItemInHand().getDurability() + 1));
                        }
 

I don't see why this gives me a stack trace when an Item I am not holding doesn't have that lore... It says something is null, but I don't see how anything here can be null, except the lore not being that. I checked if it had a lore also..

 

@TheDiamond06 The ItemMeta may be null.

 

@TheDiamond06 Thanks for the Second problem. I had to check if the ItemMeta wasn't null and also I forgot to check if it eve has a lore...

I'll try this on the first problem.

EDIT: I guess I fixed future problems on the fist problem, but it is still not changing/adding the lore.

 

@TheDiamond06
1. You tagged yourself
2. Post the entire class and try debugging.

 

@Skionz
lol tagged myself, didn't see.

This code is running, Ive already debugged it with a sendMessage

Code:java

 
                List<String>lore = new ArrayList<String>();
                lore.add(colorize(plugin.getConfig().getString("pickblockbreak")) + "1");
 
                p.getInventory().getItemInHand().getItemMeta().setLore(lore);
                p.updateInventory();
 
 

Its just not working..

 

@TheDiamond06 You're making an int a string....

 

@CodePlaysMinecraft Not exactly, putting '1' in a string, anyway I removed that, I was putting it for testing. The lore still does not add


@Skionz Full code if you really need it

Code:java

 
    @SuppressWarnings("deprecation")
    @EventHandler
    public void BlockBreakLore(BlockBreakEvent e)
    {
        Player p = e.getPlayer();
        Block b = e.getBlock();
 
        if(p.getInventory().getItemInHand().getType() == Material.WOOD_PICKAXE || p.getInventory().getItemInHand().getType() == Material.STONE_PICKAXE || p.getInventory().getItemInHand().getType() == Material.GOLD_PICKAXE || p.getInventory().getItemInHand().getType() == Material.DIAMOND_PICKAXE)
        {
            if(p.getInventory().getItemInHand() != null && p.getInventory().getItemInHand().getType() != Material.AIR && p.getInventory().getItemInHand().hasItemMeta() && p.getInventory().getItemInHand().getItemMeta().hasLore())
            {
                List<String>lore = p.getInventory().getItemInHand().getItemMeta().getLore();
                lore.add(colorize(plugin.getConfig().getString("pickblockbreak")));
 
                p.getInventory().getItemInHand().getItemMeta().setLore(lore);
                p.updateInventory();
            }
            else
            {
                List<String>lore = new ArrayList<String>();
                lore.add(colorize(plugin.getConfig().getString("pickblockbreak")));
 
                p.getInventory().getItemInHand().getItemMeta().setLore(lore);
                p.updateInventory();
            }
        }
    }
 
 

 

@Skionz I don't know exactly what you mean by debugging. Every singe line in that code is running, every line testing with p.sendMessage, the messages all send...

 

@TheDiamond06 I have no idea what colorize(String) does; therefore, you need to post the entire class.

 

@Skionz

Code:java

 
package dev.td6.prisonprofessional.events;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Material;
import org.bukkit.block.Block;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockBreakEvent;
 
import dev.td6.prisonprofessional.main.PrisonProfessionalMain;
 
public class PPEventBlockBreakLore implements Listener
{
 
    PrisonProfessionalMain plugin;
 
    public PPEventBlockBreakLore(PrisonProfessionalMain instance)
    {
        plugin = instance;
    }
 
    public String colorize(String msg)
    {
        String coloredMsg = "";
        for(int i = 0; i < msg.length(); i++)
        {
            if(msg.charAt(i) == '&')
                coloredMsg += '§';
            else
                coloredMsg += msg.charAt(i);
        }
        return coloredMsg;
    }
 
    @SuppressWarnings("deprecation")
    @EventHandler
    public void BlockBreakLore(BlockBreakEvent e)
    {
        Player p = e.getPlayer();
        Block b = e.getBlock();
 
        if(p.getInventory().getItemInHand().getType() == Material.WOOD_PICKAXE || p.getInventory().getItemInHand().getType() == Material.STONE_PICKAXE || p.getInventory().getItemInHand().getType() == Material.GOLD_PICKAXE || p.getInventory().getItemInHand().getType() == Material.DIAMOND_PICKAXE)
        {
            if(p.getInventory().getItemInHand() != null && p.getInventory().getItemInHand().getType() != Material.AIR && p.getInventory().getItemInHand().hasItemMeta() && p.getInventory().getItemInHand().getItemMeta().hasLore())
            {
                List<String>lore = p.getInventory().getItemInHand().getItemMeta().getLore();
                lore.add(colorize(plugin.getConfig().getString("pickblockbreak")));
 
                p.getInventory().getItemInHand().getItemMeta().setLore(lore);
                p.updateInventory();
            }
            else
            {
                List<String>lore = new ArrayList<String>();
                lore.add(colorize(plugin.getConfig().getString("pickblockbreak")));
 
                p.getInventory().getItemInHand().getItemMeta().setLore(lore);
                p.updateInventory();
            }
        }
    }
 
}