Text On Map Help (MapCanvas)

How do I get this (drawText) to work? Does it have to be my main class or a different one?
At the moment, I have this in my code:

Code:

public void drawText(int x, int y, MapFont font, String text) {
("Hi");
}

Why doesn't it work?

EDIT: This is my entire code:

Code:

package me.KeybordPiano459.MapTest;
 
import org.bukkit.map.MapFont;
 
public interface Main {
    public void drawText(int x, int y, MapFont font, String text) {
("Hello");
}
}

 

You need to send the map canvas to a player's map and update that map ID.

Here is a link you can use.

 

I've seen that, how do I use it though?

 

The link I sent you is a documentation of the map API and some examples :3

 

sayaad Did you ever work with maps? The documentation is crap!

You need a MapCanvas to render onto the map (MapRenderer.render() needs it as argument and also only the MapCanvas has the real rendering functions), but the MapCanvas is just a interface, so you have to create a MapCanvas for yourself and create its drawImage(x, y, image) method (as well as the other methods like get/setPixel), but no documentation at all what that method has to do or any hint how to give the image to the renderer (the interface says it's a void method).

Also the examples never show how to render. They show how to use the MapRenderer and that it needs a MapCanvas, but not how to create that damn MapCanvas. Try to copy the examples into your own code, you'll fail at the MapCanvas...

Okay, I decompiled a plugin using the map API and saw how it's done. You don't need a map canvas. I updated V10phone for it and here are some codes:

Code:java

ppackage de.V10lator.V10phone;
 
import java.awt.Image;
 
import org.bukkit.entity.Player;
import org.bukkit.map.MapCanvas;
import org.bukkit.map.MapRenderer;
import org.bukkit.map.MapView;
 
public class V10PhoneRenderer extends MapRenderer
{
  private Image onScreen;
 
  void setImageOnScreen(Image image)
  {
	onScreen = image;
  }
 
  @Override
  public void render(MapView mv, MapCanvas mc, Player p)
  {
	if(onScreen != null)
	  mc.drawImage(0, 0, onScreen);
  }
}

This is the class that actually writes on the screen. the render fucntion is called by bukkit internally, so no need to have a MapCanvas.

Now the part that sends the player a new map:

Code:java

 MapView mv = plugin.getServer().createMap(receiver.getWorld());
receiver.getInventory().addItem(new ItemStack(Material.MAP, 1, mv.getId()));
Mobile phone = new Mobile(receiver, plugin, mv);
plugin.mobiles.put(receiver, phone);

As you see it gives the MapView to the Mobile, which doesn't save it but give it to the DisplayBuffer, which has something to do with V10phones internals. The DisplayBuffer does this:

Code:java

public class DisplayBuffer
{
  private final Mobile mobile;
  V10PhoneRenderer r = new V10PhoneRenderer();
  public BufferedImage image;
  private BufferedImage screen;
  public String text;
  private boolean fullscreen = true;
  public String[] buttons = {"",""};
  Font font = new Font("FuzzballFury 5px", Font.TRUETYPE_FONT, 10);
 
  public DisplayBuffer(Mobile mobile, MapView mv)
  {
	this.mobile = mobile;
	font = font.deriveFont(5F);
	this.image = blank();
	this.text = "";
 
	mv.getRenderers().clear();
	mv.addRenderer(r);
 
	update(true);
	mobile.oldScreen = realUpdate(mobile.oldScreen);
  }
...

So it removes all previos renderers and attaches a new one in its constructor (and also saves it for later use).

Later, whenever a display update is needed it calls this:

Code:java

r.setImageOnScreen(image);

Where Image is a pre-renderet image to get painted onto the map.

But the result is suboptimal, the display refreshes in slices which makes it almost impossible to render animations. Also the map cursor is still paintet on top of the map (should be removeable).

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Use player.sendMap() at the end of your render() method to send the entire map at once to the player. You should also take care in your render() to only send changes if the data you're rendering has actually changed (some kind of "dirty" flag in your object is useful here), to avoid excessive CPU/bandwidth consumption.

See https://github.com/desht/ScrollingM...rollingmenusign/views/map/SMSMapRenderer.java for an example, where I render the contents of my commands menus onto a map. That also uses a SMSMapView object which represents the player's view (scroll position, etc.) on a SMSMenu object - a SMSMenu has one or more associated SMSView objects, SMSMapView being a subclass of SMSView, and each SMSMapView has one SMSRenderer to render the menu's contents to the player that's holding the map.

Update: and yeah, the Map API's docs leave a little to be desired I need to credit dumptruckman for providing some useful code that I was able to peruse and gain an understanding of the API.

 

Thanks.

Sure, the DisplayBuffer does this, but right now it doesn't expose it to the MapRenderer cause it was just a quick&dirty update of the old codes to see if it works at all.

 

Right, so you'll want some kind of isChanged() method in your DisplayBuffer so that the renderer can check it, I guess. And an associated setChanged() so the renderer can reset the "dirty" state after the change has been rendered. The render() method does get called every tick while a player is holding the map in his hand, so you definitely want to spend as little time as possible in it.

You might also want to look into contextual renderers, if you expect the same map ID to be held by multiple players and you want each player to see a different image on the map. That's not too hard - in your renderer constructor, just pass super(true); - that will initialize the Renderer object to use contextual canvases, i.e. it will have a separate MapCanvas object for each Player. Not sure if you're already aware of that part of the API, just putting it out there

 

As the DisplayBuffer calls setImageOnScreen only if really needed (image changed) this is a bit overkilled. I simply changed the codes to this:

Code:java

package de.V10lator.V10phone;
 
import java.awt.Image;
 
public class V10PhoneRenderer extends MapRenderer
{
  private Image onScreen;
 
  void setImageOnScreen(Image image)
  {
	onScreen = image;
  }
 
  @Override
  public void render(MapView mv, MapCanvas mc, Player p)
  {
	if(onScreen != null)
	{
	  mc.drawImage(0, 0, onScreen);
	  onScreen = null;
	}
  }
}

Which seems to work fine. But as soon as I change it to that:

Code:java

package de.V10lator.V10phone;
 
import java.awt.Image;
 
public class V10PhoneRenderer extends MapRenderer
{
  private Image onScreen;
 
  void setImageOnScreen(Image image)
  {
	onScreen = image;
  }
 
  @Override
  public void render(MapView mv, MapCanvas mc, Player p)
  {
	if(onScreen != null)
	{
	  mc.drawImage(0, 0, onScreen);
	  p.sendMap(mv);
	  onScreen = null;
	}
  }
}

The server freezes till it kicks the player and gives a (large) StackOverflowError (to big to parse at pastie). The solution is to not call p.sendMap(mv); inside of the render function but right after r.setImageOnScreen(image);

Thanks, will have a look into it.

desht Do you know how to remove the damn cursor?
I tried this:

Code:java

public class V10PhoneRenderer extends MapRenderer
{
  private Image onScreen;
  private final MapCursorCollection mcc = new MapCursorCollection();
 
  void setImageOnScreen(Image image)
  {
    onScreen = image;
  }
 
  @Override
  public void render(MapView mv, MapCanvas mc, Player p)
  {
    if(onScreen != null)
    {
      mc.setCursors(mcc);
      mc.drawImage(0, 0, onScreen);
      onScreen = null;
    }
  }
}

as well as that:

Code:java

public class V10PhoneRenderer extends MapRenderer
{
  private Image onScreen;
//  private final MapCursorCollection mcc = new MapCursorCollection();
 
  void setImageOnScreen(Image image)
  {
    onScreen = image;
  }
 
  @Override
  public void render(MapView mv, MapCanvas mc, Player p)
  {
    if(onScreen != null)
    {
      MapCursorCollection mcc = mc.getCursors();
      for(int i = 0; i < mcc.size(); i++)
        mcc.removeCursor(mcc.getCursor(i));
      mc.setCursors(mcc);
      mc.drawImage(0, 0, onScreen);
      onScreen = null;
    }
  }
}

But the cursor won't go away...

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

V10lator I didn't do anything specific to remove the cursors in my SMSMapRenderer and I don't have any cursors on the map, so I would guess removing the default renderer is what does the trick there. See setMapId() in https://github.com/desht/ScrollingM...desht/scrollingmenusign/views/SMSMapView.java.

Update: yeah, looking at your original code, you have:

PHP:

mv.getRenderers().clear();


But getRenderers() returns a copy of the view's renderer list, so calling clear() like that won't work. You need to call removeRenderer() like so:

PHP:

for (MapRenderer r : view.getRenderers()) {
  mv.removeRenderer(r);
}


 

desht But I'm removing all renderers:

Code:java

mv.getRenderers().clear();
mv.addRenderer(r);

Or is clear() not working like expected here?

 

See above

 

Arrgh... Am I allowed to call this a stupid decision of the bukkit team? ^^
Anyway, your solution works perfectly. Thanks.

 

Oh great now I need to find a new documentation >.>

Why didn't I start with the official documentation?

*Head Desk*

Bookmarking this page for future reference...

 

Cause it's the same (or even more) crap?
But well, we figured it out. Would be nice if somebody would write a tutorial about it into the resources section so other devs are able to figure it out more easy...