Runnable help.

Hi, i have a runnable in my plugins onEnable() and it has p.getLocation() in it. But, p is red because it's not a valid vaiable. That's where the issue arises i can't figure out how to make a player variable global in the class or add one to the onEnable(). All help greatly appreciated!

 

Try adding the final modifier to the variable you are trying to use.

 

Any variable used in an anonymous context has to be effectively final if it is from outside the class' scope.

 

Tzeentchful
1Rogue

It's already final.

 

Could we get the clipping of your code in which you are having problems?

 

xYourFreindx
I changed it up a lot. I fixed the double runnables but now whenever someone types /tceffect <effect> it takes away another players effect and if someone else does it it takes another players away. In short only one person can have it.
Also happens with /tceffect stop.

Code:

Code:java

package me.rockindavies21.tcparticleeffects;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class TCParticleEffects extends JavaPlugin implements Listener{
 
    public double radialsPerStep = Math.PI / 8;
 
    public float radius = .4f;
 
    protected float step = 0;
 
    public Player p;
 
    public int hearts;
 
    List<String> Main = new ArrayList<String>();
 
    List<String> effecthearts = new ArrayList<String>();
    List<String> effectwater = new ArrayList<String>();
    List<String> effectwitch = new ArrayList<String>();
    List<String> effectslime = new ArrayList<String>();
 
    @Override
    public void onEnable() {
        getServer().getPluginManager().registerEvents(this, this);
 
        hearts = Bukkit.getServer().getScheduler().scheduleSyncRepeatingTask(this, new Runnable() {
 
            @Override
            public void run() {
                Location location = p.getLocation();
                location.add(0, 1.9f, 0);
                location.add(Math.cos(radialsPerStep * step) * radius, 0, Math.sin(radialsPerStep * step) * radius);
                if(effecthearts.contains(p.getName())){
                ParticleEffect.HEART.display(location, 0, 0, 0, .5f, 1);
                step++;
                }
 
                if(effectwater.contains(p.getName())){
                    ParticleEffect.DRIP_WATER.display(location, 0, 0, 0, .5f, 1);
                    step++;
                    }
                if(effectwitch.contains(p.getName())){
                    ParticleEffect.WITCH_MAGIC.display(location, 0, 0, 0, .5f, 1);
                    step++;
                    }
                if(effectslime.contains(p.getName())){
                    ParticleEffect.SLIME.display(location, 0, 0, 0, .5f, 6);
                    step++;
                    }
 
 
            }
 
        }, 0, 2L);
 
    }
 
    @Override
    public void onDisable() {
 
    }
 
    public boolean onCommand(CommandSender sender, Command cmd,  String commandLabel, String[] args){
        p = (Player) sender;
        if(commandLabel.equalsIgnoreCase("tceffect")){
            if(p.hasPermission("tc.effects")){
 
                if(args[0].equalsIgnoreCase("stop")){
                    effecthearts.remove(p.getName());
                    effectwater.remove(p.getName());
                    effectwitch.remove(p.getName());
                    effectslime.remove(p.getName());
                    Main.remove(p.getName());
                    return true;
                }
            if(Main.contains(p.getName())){
            p.sendMessage(ChatColor.GREEN + "You already have an active effect!");
                return true;
            }
 
        if(args.length > 0){
            if(args[0].equalsIgnoreCase("hearts")){
                p.sendMessage(ChatColor.GREEN + "Heart effect activated!");
                effecthearts.add(p.getName());
                Main.add(p.getName());
                return true;
 
            }
        }
        }
 
            if(args[0].equalsIgnoreCase("water")){
                p.sendMessage(ChatColor.GREEN + "Water effect activated!");
                effectwater.add(p.getName());
                Main.add(p.getName());
                return true;
 
            }
 
            if(args[0].equalsIgnoreCase("witch")){
                p.sendMessage(ChatColor.GREEN + "Witch effect activated!");
                effectwitch.add(p.getName());
                Main.add(p.getName());
                return true;
 
            }
 
            if(args[0].equalsIgnoreCase("slime")){
                p.sendMessage(ChatColor.GREEN + "Witch effect activated!");
                effectslime.add(p.getName());
                Main.add(p.getName());
                return true;
 
            }
 
        }
        return false;
}
 
 
    @EventHandler
    public void onQuit(PlayerQuitEvent e){
        Player p = e.getPlayer();
        Main.remove(p.getName());
        if(effecthearts.contains(p.getName())){
            effecthearts.remove(p.getName());
        }
        if(effectwater.contains(p.getName())){
            effectwater.remove(p.getName());
        }
        if(effectwitch.contains(p.getName())){
            effectwitch.remove(p.getName());
        }
        if(effectslime.contains(p.getName())){
            effectslime.remove(p.getName());
        }
 
 
 
    }
}
 

 

Why are you doing all this in your onEnable?
What exactly are you trying to achieve?

 

The variable 'p' is going to throw plenty of null pointer exceptions until you actually set it to something...

 

So

1. Player p; <- that doesn't have a final modifier.
2. You have a Player object that you haven't initialized that you are trying to do things to. Should give http://en.wikipedia.org/wiki/Rubber_duck_debugging a shot.

 

xYourFreindx
I'm creating a particle effects plugin.
Garris0n
p is set on line 78.
drtshock
Fixed. Also, that rubber duck method sounds interesting i'll give it a shot

 

Rockindavies21 onenable would fire before oncmmand.. I don't think you understand when onenable fires and whats its purpose.

 

Fields qualify as "effectively final" by anonymous contexts

The real crime here is a global player variable that can be represented by anything and has no real state management.

 

onEnable says *When the plugins gets loaded by the server*, an event that doesn't involve players. So you're casting player to a null object. You've got to describe what players you're talking about to the program. I'd suggest using the onPlayerJoin event. Since its the first thing to trigger when a player joins.

 

Instead of doing this all in onEnable, create an object class (getters / setters) to handle actual particle effects for ONE player. When they type a commands (or whatever), create a new instance of the class, and run it that way. Then, the class only works for ONE player, so you can have each player with a separate trail. Welcome to OOP.

 

ever_x
Could you explain in more detail?
I'm really confused

 

Rockindavies21 Please only bump once every 24 hours.

 

Create a new Object by creating a new class.
<Edit by Moderator: Redacted bit url>
Every time a player joins, create another instance of your object to store that players data.

 

MeRPG
Read through it a lot. Makes sense.

Is this the correct way to do it?
The only issue i have is at "new Player" Player is red because i didn't put the code correctly in the parenthesis...
Not exactly sure what to put in there.

Code:

Code:java

package me.rockindavies21.tcparticleeffects;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
 
public class PlayerJoin implements Listener{
 
    Player p;
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e){
        Player player = new Player(p.getName());
 
    }
 
 
}
 

 

Rockindavies21 You don't create a new player instance, you create a new instance of your own class, but pass in a Player object into the constructor.

 

ever_x
I completely recoded the plugin. Now when i type /tceffect hearts i get kicked with internal server error.
Error:

Code:

[18:59:03] [Server thread/WARN]: Failed to handle packet for /xx.xxx.xxxxxxx
java.lang.NullPointerException
    at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:101) ~[spigot.jar:git-Spigot-1451]
    at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:425) ~[spigot.jar:git-Spigot-1451]
    at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:406) ~[spigot.jar:git-Spigot-1451]
    at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:367) [spigot.jar:git-Spigot-1451]
    at org.apache.logging.log4j.core.Logger.log(Logger.java:110) [spigot.jar:git-Spigot-1451]
    at org.apache.logging.log4j.spi.AbstractLogger.error(AbstractLogger.java:609) [spigot.jar:git-Spigot-1451]
    at org.bukkit.craftbukkit.v1_7_R3.util.ForwardLogHandler.publish(ForwardLogHandler.java:33) ~[spigot.jar:git-Spigot-1451]
    at java.util.logging.Logger.log(Logger.java:610) ~[?:1.7.0_51]
    at java.util.logging.Logger.doLog(Logger.java:631) ~[?:1.7.0_51]
    at java.util.logging.Logger.log(Logger.java:720) ~[?:1.7.0_51]
    at net.minecraft.server.v1_7_R3.PlayerConnection.handleCommand(PlayerConnection.java:991) ~[spigot.jar:git-Spigot-1451]
    at net.minecraft.server.v1_7_R3.PlayerConnection.a(PlayerConnection.java:830) ~[spigot.jar:git-Spigot-1451]
    at net.minecraft.server.v1_7_R3.PacketPlayInChat.a(PacketPlayInChat.java:28) ~[spigot.jar:git-Spigot-1451]
    at net.minecraft.server.v1_7_R3.PacketPlayInChat.handle(PacketPlayInChat.java:65) ~[spigot.jar:git-Spigot-1451]
    at net.minecraft.server.v1_7_R3.NetworkManager.a(NetworkManager.java:176) ~[spigot.jar:git-Spigot-1451]
    at net.minecraft.server.v1_7_R3.ServerConnection.c(ServerConnection.java:77) [spigot.jar:git-Spigot-1451]
    at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:713) [spigot.jar:git-Spigot-1451]
    at net.minecraft.server.v1_7_R3.DedicatedServer.v(DedicatedServer.java:283) [spigot.jar:git-Spigot-1451]
    at net.minecraft.server.v1_7_R3.MinecraftServer.u(MinecraftServer.java:576) [spigot.jar:git-Spigot-1451]
    at net.minecraft.server.v1_7_R3.MinecraftServer.run(MinecraftServer.java:482) [spigot.jar:git-Spigot-1451]
    at net.minecraft.server.v1_7_R3.ThreadServerApplication.run(SourceFile:628) [spigot.jar:git-Spigot-1451]

 

Bump

 

Rockindavies21 I don't know how your re-worked code works, but from your first code, you could have just surrounded the code in your runnable with a for loop that loops through the online players. You wouldn't need to make a global variable for the player. Using a global variable for a player makes me think that there will only be one player that this would apply to. If you want this to be for only one player, forget the for loop and use the getPlayer() method and check to see if the player isn't null before running the rest of the code.

 

Locked. I'm sorry, but you are not using CraftBukkit software and we don't support unofficial builds. Please seek support from the makers of your server software.