Reactivate PlayerInteractEvent

Hi bukkit, I've a question, i tried to create a automatic gun, but the PlayerInteractEvent only works the time it gets activated :s Is there a way to check if a player is still pressing left/right button outside the PlayerInteractEvent or is there a way to let it check every tick the playerInteractEvent?

 

i don't understand. it sounds like all of your code for the automatic gun is inside the method where the listener fires the PlayerInteractEvent. make a separate class (ex. Gun.java) or something, move all of your code inside the class and you can reference whatever code you want from the class.

 

bennie3211 (AFAIK) The PlayerInteractEvent will continually fire if their mouse is held down. You can combine this with a simple cooldown system (a proper one, not a scheduler one, scheduler will destroy the server if used like this) to add like a small 300~ ms cooldown to put small gaps between each shot.

 

xTigerRebornx k9rosie Why will this not work then?

this is the gunMethode, and the playerinteractevent. I even added last time some debug messages, but they didn't get spammed in the console when i hold the left mouse button :s

Code:java

    public void onShootGun(final Player pl) {
 
        final String name = pl.getName();
 
        if (!shooting.contains(name)) {
            return;
        }
 
        if (!hasGun(pl)) {
            shooting.remove(name);
            return;
        }
 
        Guns gun = getGun(pl);
 
        Double precision = gun.getPrecision();
        Integer firedBullets = gun.getFiredBullets();
        long shootTime = gun.getShootTime();
        Short weaponDamage = gun.getWeaponDamage();
        Sound sound = gun.getSound();
        Vector v = pl.getLocation().getDirection();
 
        for (int i = 0; i < firedBullets; i++) {
            Snowball b = pl.launchProjectile(Snowball.class);
            Vector vo = v.multiply(5);
            vo.add(new Vector(Math.random() * precision - precision, Math.random() * precision - precision, Math.random() * precision - precision));
            b.setVelocity(vo);
        }
 
        pl.sendMessage(weaponDamage + "");
 
        pl.getWorld().playSound(pl.getLocation(), sound, 1.2F, 1.2F);
 
        Plugin plugin = Bukkit.getServer().getPluginManager().getPlugin("WarZ");
 
        plugin.getServer().getScheduler().scheduleSyncDelayedTask(plugin,
            new Runnable() {
 
                @Override
                public void run() {
 
                    shooting.remove(name);
                }
 
        }, shootTime);
    }
 
    @EventHandler
    public void onShoot(PlayerInteractEvent event) {
 
        Player pl = event.getPlayer();
 
        if ((event.getAction() != Action.LEFT_CLICK_AIR) && (event.getAction() != Action.LEFT_CLICK_BLOCK)) {
            return;
        }
 
        if (!hasGun(pl)) {
            return;
        }
 
        if (!shooting.contains(pl.getName())) {
            shooting.add(pl.getName());
            onShootGun(pl);
        }
    }

And yes, this is a small part of the plugin, it works, but not the way I thought it would be :L I have to press the left button again before i can shoot again.

 

bennie3211 Left click can not be held down unless you are left clicking a block (normal minecraft behavior). Right click is repeatedly fired if you hold it down.
If you want to make an "automatic" gun, I'd suggest using right click.
And please use proper cooldowns. If you do plan on having an automatic gun, you are going to be creating a massive number of new tasks trying to cooldown.
http://forums.bukkit.org/threads/easycooldown.128219/ Read the comment made by Comphenix, it shows a proper way of creating cooldowns.

 

Thnx I will remake the cooldown system tomorrow