Solved Random Teleportation not working.

Hello.

I've just been making a little bit of code for a Random Teleporter.
I'm not sure why this isn't working. Can I have a little help please!

Code:java

package com.InsertAPI.listeners;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.GameMode;
import org.bukkit.Location;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
 
public class JoinLeave implements Listener {
 
    Location spawn1 = new Location(Bukkit.getServer().getWorld("world"), -52, 69, 242);
    Location spawn2 = new Location(Bukkit.getServer().getWorld("world"), -49, 68, 242);
    Location spawn3 = new Location(Bukkit.getServer().getWorld("world"), -49, 68, 239);
    Location spawn4 = new Location(Bukkit.getServer().getWorld("world"), -52, 69, 239);
 
    @EventHandler
       public void onPlayerJoin(PlayerJoinEvent e){
       Player p = e.getPlayer();
        p.teleport(spawn1 || spawn2 || spawn3 || spawn4); // supposed to pick a random one.
       }
}

 

Hello there!
Sorry for the late reply.

Can you give me some links to get started please? I have never used 'random' before.

 

Also, just a suggestion: I would recommend putting your locations in a collection to make it easier if you ever wanted to add more.

 

Thank you so much!

A quick question, is the most efficient way to do it?

Code:java

Random random = new Random();
        int Chance = random.nextInt(4);
 
        if(Chance == 0) {
            p.teleport(spawn1);
        }else if(Chance == 1){
            p.teleport(spawn2);
        }else if(Chance == 2){
            p.teleport(spawn3);
        }else if(Chance == 3){
            p.teleport(spawn4);
        }

 

Alright!

Thanks so much!