Player can still move while frozen?

Code:java

 
public class Main extends JavaPlugin implements Listener{
    public ArrayList<String> freeze = new ArrayList<String>();
 
    @Override 
    public void onEnable(){
        getLogger().info("cFreeze is now enabled!");
    }
 
    @Override
    public void onDisable(){
        getLogger().info("cFreeze has been disabled!");
    }
 
    @EventHandler
      public void onPlayerMove(PlayerMoveEvent e){
        if(freeze.contains(e.getPlayer().getName())){
                e.getPlayer().teleport(e.getPlayer());
                e.getPlayer().sendMessage(ChatColor.BLUE + "You Are Frozen!");
        }else{
 
        }
}
 
    @EventHandler
    public void onLogout(PlayerQuitEvent e){
        Player p = e.getPlayer();
        if(freeze.contains(e.getPlayer())){
            for (Player online : Bukkit.getOnlinePlayers()) {
                if(online.hasPermission("freeze.seelogger")){
                    online.sendMessage(ChatColor.RED + p.getName() + " has logged while frozen!");
                    online.sendMessage(ChatColor.RED + p.getName() + " has logged while frozen!");
                    online.sendMessage(ChatColor.RED + p.getName() + " has logged while frozen!");
                    online.sendMessage(ChatColor.RED + p.getName() + " has logged while frozen!");
                    online.sendMessage(ChatColor.RED + p.getName() + " has logged while frozen!");
                    online.sendMessage(ChatColor.RED + p.getName() + " has logged while frozen!");
                }
            }
 
        }
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] args) {
        Player target;
        if(cmd.getName().equalsIgnoreCase("freeze")){
            if(sender.hasPermission("cfreeze.freeze")){
                if(args.length < 1){
                    sender.sendMessage(ChatColor.RED + "/Freeze <Name>");
                } else {
                    target = Bukkit.getServer().getPlayer(args[0]);
                    if(target != null){
                        if(!freeze.contains(target.getName())){
                            freeze.add(target.getName());
                            target.sendMessage(ChatColor.RED + "You have been frozen! If you log out, you will be banned!");
                            sender.sendMessage(ChatColor.GREEN + target.getName() + " has been frozen!");
                        } else if(freeze.contains(target.getName())){
                            freeze.remove(target.getName());
                            sender.sendMessage(ChatColor.GREEN + target.getName() + " has been unfrozen!");
                            target.sendMessage(ChatColor.RED + "You have been unfrozen!");
                        }
                    }
                }
            }
        }
        return false;
    }
 
}
 
 

I don't get why this is happening... it just makes it so that they teleport to eachother but even cancelling the move event does nothing. When a player logs out, it doesn't spam me with the messages like it should either... whats going on?

 

@football70500 You are not registering events!

Code:

this.getPlugin().getServer().getPluginManager().registerEvents(this, this); // in on on enable

 

@meguy26 DUH! one more question, how come it isn't sending the message when the player frozen logs out to the people with the perms.

 

@football70500
*shrugs*
Anyway, you should be using UUID lists instead of player lists, if you use player lists and a player logs out, your list keeps them in the memory, and can slow the server...

EDIT: never mind, I need to start reading things before I say something...

 

At best, you might want to make a test if they are on ground, because freezing someone in mid-air or in water can get glitchy. Especially if you have the NoCheatPlus plugin, it'll kick them. Make sure to register the listener events.

Adding on to what others said;
Also for the PlayerMoveEvent, it's more reliable if you do this:

Code:

@EventHandler
      public void onPlayerMove(PlayerMoveEvent e){
        if(freeze.contains(e.getPlayer().getName())){
                e.setCancelled(true); //less work.
                e.getPlayer().sendMessage(ChatColor.BLUE + "You Are Frozen!");
        }else{
               return;
        }

 

@football70500
I figured out why it is not sending message, in PlayerQuitEvent you are checking if(freeze.contains(ev.getPlayer())) But you need to check the name, if(freeze.contains(ev.getPlayer().getName()))

 

Thanks for that! I want to make it now so that if a player is frozen they can't take pvp
damage, but i can't figure out how to check if my entity is a player that is in the list...

Code:java

 
    @EventHandler
    public void onDamageTake(EntityDamageEvent e) {
        Entity p = e.getEntity();
        if (p instanceof Player) {
            if (freeze.contains(p)) {
                if (e.getCause() == DamageCause.CONTACT) {
                    e.setCancelled(true);
                }
            }
        }
 
    }

 

@football70500 Please learn the basics of Java. Bukkit is written in Java, so you cannot make plugins without first learning Java. Trying to do so will just result in problems. I recommend following the Oracle tutorials or a Java book.

 

@football70500
Same problem as earlier:

 

But i can't return .getName() because its an entity, not a player

 

@football70500
cast it to a player:

Code:

Entity someEntity = ignorethispart;
if(someEntity instanceof Player){
    Player player = (Player) someEntity; //we know the entity is a player so we can tell java that by casting.
    if(freeze.contains(player.getName())){
        //do stuff
    }
}

 

@football70500 No need to be rude - my advice is genuine I'm not claiming to be perfect, claiming that you need to be perfect, or claiming that you know no Java at all. I'm simply stating that you do not know enough Java to be making plugins. It's quite clear from the fact that you didn't realise you needed a cast, and that you made the exact same mistake twice - a contains check that couldn't possibly be true.

Trust me, I've been doing this long enough to be able to spot these telltale signs that someone needs more Java knowledge - my advice is not meant to be taken as an insult. Please follow my advice and you will be a much better at making plugins

 

@meguy26 i forgot to comment, i realized i had to do that, thanks.

 

@AdamQpzm
hmm.. well, I have been doing this long enough to realize that some people learn their own way, and that the best way to infuriate, discourage, and disappoint them is to tell the they do not know enough. I for one am a bit fast on the uptake, but no one, not even me or you, can learn all of Java and then ask questions about why there code does not work; only perfect developers can do that therefore everyone who creates threads in this section does not know everything about Java. I learned what static meant last week... but I am relatively adept at Java, we all learn different things, at different paces, in different ways, and often we accidentally skip over certain things such as casting.

All that aside, @football70500 your questions were pretty simple, so I suggest you maybe look into learning more Java, it is clear you are adept at it, but maybe instead of a Bukkit Plugin, do something a bit more immersive, try to make a 2D game, so that you can practice coding, instead of asking easy-to-solve questions.


No offense to any party involved, but honestly, calm down about this whole "must make learn java" thing!

 

@meguy26

The point being that these are not Java forums, if they were, we wouldn't have an issue with people asking questions about Java here. They are Bukkit forums, and are for questions specific to the Bukkit API. Any questions asking about simple Java topics are:

1. Not on topic for these forums
2. In all likelihood extremely well documented on Google

That's why me and Adam are so adamant about this, because it really does plug up these forums with irrelevant questions.

You came here asking for our help, learn some humility.

 

To prevent spazms just teleport the player to themself when they move