Solved p.getIteminHand HELP!

Hi guys, im creating a /sharpness plugin(when you type the command, one level of sharpness is addict in your sword) But when i do the command, my debug code says i dont have a sword in my hand, can anyone help?

Code:java

 
public class Main extends JavaPlugin {
 
    public static Economy econ = null;
    public void onEnable(){
        if (!setupEconomy() ) {
            getLogger().severe(String.format("O PLUGIN FOI DESABILITADO, VAULT NAO FOI ENCONTRADO!", getDescription().getName()));
            getServer().getPluginManager().disablePlugin(this);
            return;
        }
        System.out.println("PL FEITO POR MASTEREGGLUIGI");
        System.out.println("SKYPE: LUIGIEAI");
        level=0;
    }
 
    private boolean setupEconomy() {
        if (getServer().getPluginManager().getPlugin("Vault") == null) {
            return false;
        }
        RegisteredServiceProvider<Economy> rsp = getServer()
                .getServicesManager().getRegistration(Economy.class);
        if (rsp == null) {
            return false;
        }
        econ = rsp.getProvider();
        return econ != null;
    }
    public int level;
      public boolean onCommand(CommandSender sender, Command command, String cmd, String[] args)
      {
        Player p = (Player)sender;
      if(cmd.equalsIgnoreCase("Sharpness")){
          EconomyResponse r = econ.withdrawPlayer(p.getName(), 20);
          if (r.transactionSuccess()) {
              if(p.getInventory().getItemInHand().equals(Material.DIAMOND_SWORD)){
                  level = p.getInventory().getItemInHand().getEnchantmentLevel(Enchantment.DAMAGE_ALL);
                  p.getItemInHand().addEnchantment(Enchantment.DAMAGE_ALL,
                          level+1);
                  p.sendMessage(ChatColor.GREEN+"Sharpness foi adicionado por 20 creditos!"); 
              }
              if(p.getInventory().getItemInHand().equals(Material.IRON_SWORD)){
                  level = p.getInventory().getItemInHand().getEnchantmentLevel(Enchantment.DAMAGE_ALL);
                  p.getItemInHand().addEnchantment(Enchantment.DAMAGE_ALL,
                          level+1);
                  p.sendMessage(ChatColor.GREEN+"Sharpness foi adicionado por 20 creditos!"); 
              }
              if(p.getInventory().getItemInHand().equals(Material.GOLD_SWORD)){
                  level = p.getInventory().getItemInHand().getEnchantmentLevel(Enchantment.DAMAGE_ALL);
                  p.getItemInHand().addEnchantment(Enchantment.DAMAGE_ALL,
                          level+1);
                  p.sendMessage(ChatColor.GREEN+"Sharpness foi adicionado por 20 creditos!"); 
              }
              if(p.getInventory().getItemInHand().equals(Material.STONE_SWORD)){
                  level = p.getInventory().getItemInHand().getEnchantmentLevel(Enchantment.DAMAGE_ALL);
                  p.getItemInHand().addEnchantment(Enchantment.DAMAGE_ALL,
                          level+1);
                  p.sendMessage(ChatColor.GREEN+"Sharpness foi adicionado por 20 creditos!"); 
              }
              if(p.getInventory().getItemInHand().equals(Material.WOOD_SWORD)){
                  level = p.getInventory().getItemInHand().getEnchantmentLevel(Enchantment.DAMAGE_ALL);
                  p.getItemInHand().addEnchantment(Enchantment.DAMAGE_ALL,
                          level+1);
                  p.sendMessage(ChatColor.GREEN+"Sharpness foi adicionado por 20 creditos!"); 
              }else{
                  p.sendMessage(ChatColor.RED+"Voce nao esta com uma espada na mao!");//The error code that say i dont have a sword in hand!
                  return true;
              }
              return true;
              }
          return true;
            }
        return false;
      }

Why my plugin isn't reconizing the item in hand.
PS:Sorry my bad english

 

Change p.getInventory().getItemInHand().equals(Material.DIAMOND_SWORD)
for this
p.getItemInHand().getType()==Material.DIAMOND_SWORD

 

Konato_K
Ok thanks bro, i can ask why?

 

luigieai getItemInHand() returns an ItemStack, and you're comparing it with a Material, it will never return true, so you need to use getItemInHand().getType() which returns a Material, since Material is an enum you can use == instead of .equals(), players have a method getItemInHand(), so there is no need to call getInventory().

Also, I suggest you to first check if the item in hand is null, so you will not get NPEs

 

Konato_K
Ok i wil do this, thanks!

 

luigieai Konato_K

.equals() is a better way of comparing enums then ==

 

ZodiacTheories Not really, if for example the Material returned by ItemStack#getType() is null, calling .equals(Object) will throw a NullPointerException, while using the == operator won't.

 

ZodiacTheories now argue why

 

Traks fireblast709

Sorry

I always thought that .equals was better for comparing enums - I didn't mean it in a passive-aggressive way.

 

ZodiacTheories You learn something new every day!

 

Traks