No item dropping

Code:

package me.nebuler;

import java.util.List;

import org.bukkit.World;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Item;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockBreakEvent;
import org.bukkit.event.player.PlayerDropItemEvent;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.java.JavaPlugin;

public class NoDrop extends JavaPlugin implements Listener {
   
    @EventHandler
    public void ondrop(PlayerDropItemEvent event) {
        event.getItemDrop().remove();
    }
    
    @EventHandler
    public void onBlockDrop(BlockBreakEvent event) {
       
        Player player = event.getPlayer();
        player.setCanPickupItems(false);
        World world = this.getServer().getWorld(player.getWorld().getName());
        List<Entity> entList = world.getEntities();
        for (Entity current : entList) {
            if (!(current instanceof Item)) continue;
            current.remove();
        }
       
    }
   
    public void onEnable() {
        this.getServer().getPluginManager().registerEvents((Listener)this, (Plugin)this);
    }
}

I'd like to make it so no items can be dropped onto the ground and are removed. I have this code but the items can still be dropped. Thanks in advance - Nebuler

 

You cast a Listener to Listener and a Plugin to a Plugin?
Have you debuged?

 

@mine-care Haven't debugged yet, but was guessing it was an easy fix

Is the registerEvents line pointless?

 

Well you dont need to loop through all the entities, you can just get the drops by the event...
other than this it seems fine, take the time to debug

 

@mine-care

how do I do that?

 

@Nebuler @mine-care
You can't get the drops from a BlockBreakEvent, and the dropped items are not in the world's entity list. You need to listen for an ItemSpawnEvent and cancel that

 

@megamichiel

Code:

package me.nebuler;

import java.util.List;

import org.bukkit.World;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Item;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockBreakEvent;
import org.bukkit.event.entity.ItemSpawnEvent;
import org.bukkit.event.player.PlayerDropItemEvent;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.java.JavaPlugin;

public class NoDrop extends JavaPlugin implements Listener {
  
    @EventHandler
    public void ondrop(PlayerDropItemEvent event) {
        event.getItemDrop().remove();
    }
   
    @EventHandler
    public void onBlockDrop(BlockBreakEvent event) {
      
        Player player = event.getPlayer();
        player.setCanPickupItems(false);
        World world = this.getServer().getWorld(player.getWorld().getName());
        List<Entity> entList = world.getEntities();
        for (Entity current : entList) {
            if (!(current instanceof Item)) continue;
            current.remove();
        }
      
    }
  
    @EventHandler
    public void onBlockDropSpawn(ItemSpawnEvent event) {
      
        event.setCancelled(true);
      
    }
  
    public void onEnable() {
        this.getServer().getPluginManager().registerEvents((Listener)this, (Plugin)this);
    }
}

I added the item spawn event so now when you break a block in survival it isn't dropped, but what should I do about the block break event? Delete it? Also, when you drop an item with q it is not deleted which im pretty sure should happen because I have this:

Code:

@EventHandler
    public void ondrop(PlayerDropItemEvent event) {
        event.getItemDrop().remove();
    }

But I may be wrong...

 

This only get triggered when a player drops an item.

player.setCanPickupItems will make sure the players can no longer pick up any item. If there won't be any items on the ground, this line will be useless.

To stop items from being dropped, listen to the Entitiy Spawn Event. If the entitiy is an instance of an Item, remove it.

 

@Zombie_Striker could you just post the fixed code for that?

 

@Nebuler
Spoonfeeding is not* allowed on the forums.

Also, what I said you should do can be done in Three-Lines

 

@Zombie_Striker

Not an event

 

@Nebuler
Sorry, It's CreatureSpawnEvent.

 

@Zombie_Striker sorry haven't used the creaturespawnevent yet, what's the line to check if the 'creature' is an item drop?

 

Instead of removing the item once it's dropped,
just put "event.setCancelled(true) into your "PlayerDropItemEvent".
They will not be able to drop it.

@Zombie_Striker Did you mean to say "Spoonfeeding is not allowed on the forums." or "now allowed"?

 

@Kyorax i want the player's to be able to drop the item.

 

@Nebuler "I'd like to make it so no items can be dropped onto the ground and are removed"
My interpretation was that they can't drop them.

And to help you with your code:
As Zombie_Striker pointed out, remove the "playerCanPickUp"-line, it's useless when there are no items to be picked up.
If you want to listen to all drops, don't use the PlayerDropItemEvent. You also need to check the BlockBreakEvent.

 

@Kyorax what events should I listen to then?

 

Get the dropped item in the BlockBreakEvent and remove it. That should do it.

 

@Kyorax how do you get the item drop from that event?

 

@Nebuler @Kyorax
You can get the item by using .getDrops(), but then you are using two events to make sure players can't drop items, and that blocks can't drop items. If you don't want any items to drop. Just do the following:

Code:

public void spawnEvent(CreatureSpawnEvent e){
if(entitiy instance of Item)
entitiy.remove();
}

 

@Zombie_Striker I have this:

Code:

@EventHandler
    public void onBlockDrop(CreatureSpawnEvent event) {
      
        Entity entity = event.getEntity();
      
        if(entity instanceof Item) {
      
            entity.remove();
          
        }

And on the line entity.remove(); I have a syntax error on the semicolon: 'Syntax error, insert "}" to complete Statement' No idea why this would be

EDIT: facepalm, forgot a brace to close the spawnevent

@Zombie_Striker

Code:

package me.nebuler;

import org.bukkit.entity.Entity;
import org.bukkit.entity.Item;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.CreatureSpawnEvent;
import org.bukkit.event.player.PlayerDropItemEvent;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.java.JavaPlugin;

public class NoDrop
extends JavaPlugin
implements Listener {
    @EventHandler
    public void ondrop(PlayerDropItemEvent event) {
        event.getItemDrop().remove();
    }
  
    @EventHandler
    public void onBlockDrop(CreatureSpawnEvent event) {
      
        Entity entity = event.getEntity();
      
        if(entity instanceof Item) {
      
            entity.remove();
          
        }
    }

    public void onEnable() {
        this.getServer().getPluginManager().registerEvents((Listener)this, (Plugin)this);
    }
}

Items are removed when the block is broken in survival or dropped with q but not when shot out of a dispenser
Also, I need it so that when items are in a chest/ dropper/ hopper or whatever and the 'container' is broken, I don't want the items that were in it to be dropped and just be removed.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bump

 

Bump

bumpety bumpy

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

@Nebuler The javadocs are your friend.

 

@Oxyorum that doesn't help, I can't find a method to do what I want, that's why i'm asking on here.

 

@Nebuler
let me just fix your code. Maybe ill see the problem afterwards

Code:

public class NoDrop extends JavaPlugin implements Listener {

    public void onEnable() {
        this.getServer().getPluginManager().registerEvents((Listener)this, (Plugin)this);
//   You don't need to cast. This class does extend JavaPlugin and does implment listener. So reemove casting
    }

    @EventHandler
    public void ondrop(PlayerDropItemEvent event) {
        event.getItemDrop().remove();
//      This whole method should not be necessary. 
    }
    @EventHandler
    public void onBlockDrop(CreatureSpawnEvent event) {
    
        Entity entity = event.getEntity();
    
        if(entity instanceof Item || entitiy.getType() == EntitiyType.ITEM) {
            entity.remove();
        }
    }
}

 

@Zombie_Striker sure that's not the same as

Code:

@EventHandler
    public void onBlockDrop(CreatureSpawnEvent event) {
       
        Entity entity = event.getEntity();
       
        if(entity instanceof Item) {
       
            entity.remove();
           
        }
    }

 

@Zombie_Striker @Nebuler I'm curious, why are you not using ItemSpawnEvent instead of CreatureSpawnEvent?

 

@Nebuler

Use this because I have on idea why it's not removing all items.\

EDIT] Oxyorum is right. nvm

 

@Zombie_Striker

Code:

@EventHandler
    public void onBlockDrop(ItemSpawnEvent event) {
       
        Entity entity = event.getEntity();
       
        entity.remove();
    }

Will work?