Major Plugin Help

Okay. Basically, im coding for a new server coming out, but im using teams and array lists and to be honest, im completely lost. I've tried doing so many things that just don't work, i've never worked with teams before so i'm not 100% sure how that all works along with other things. Anyway, i want some help looking over my code, as i know its not right as it already has bugs.

Code:java

package me.aperxmc.youtube;
 
import java.util.HashSet;
import java.util.Set;
import java.util.logging.Logger;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
import org.bukkit.scoreboard.Scoreboard;
import org.bukkit.scoreboard.ScoreboardManager;
import org.bukkit.scoreboard.Team;
 
public class Maingame extends JavaPlugin {
 
public final Logger logger = Logger.getLogger("Minecraft");
private final String PREFIX = ChatColor.DARK_GRAY + "[" + ChatColor.RESET + ChatColor.DARK_RED + ChatColor.BOLD.toString() + "AoA" + ChatColor.RESET + ChatColor.DARK_GRAY + "] "  + ChatColor.RESET;
private final String GP = ChatColor.GOLD + ChatColor.BOLD.toString() + "[" + ChatColor.RESET + ChatColor.DARK_AQUA + "Guard" + ChatColor.GOLD + ChatColor.BOLD.toString() + "]";
private final String AP = ChatColor.GOLD + ChatColor.BOLD.toString() + "[" + ChatColor.RESET + ChatColor.RED + "Assasin" + ChatColor.GOLD + ChatColor.BOLD.toString() + "]";
public static final FriendlyFireHandler FFH = new FriendlyFireHandler();   
private ScoreboardManager sbMgr;
public Scoreboard sbMain;
    public static Maingame plugin;
 
    @Override
    public void onEnable(){
        // TODO Insert logic to be performed when the plugin is enabled
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info( "Attack of the Assasins Version " + pdfFile.getVersion() + " Has Begun! Coded By Aperx. Designed by Doooogle");
        PluginManager pm = getServer().getPluginManager();
        this.sbMgr = Bukkit.getScoreboardManager();
        this.sbMain = this.sbMgr.getMainScoreboard();
        Guards.clear();
        Assasins.clear();
 
 
 
    }
 
 
    @Override
    public void onDisable() {
        // TODO Insert logic to be performed when the plugin is disabled
        PluginDescriptionFile pdfFile = this.getDescription();
        this.logger.info("Attack of the Assasians Version " + pdfFile.getVersion() + " Has Ended! Thankyou for Using us! Coded by Aperx, Designed by Doooogle");
        Guards.clear();
        Assasins.clear();
    }
 
  static Set<String> Assasins = new HashSet<String>();
  static Set<String> Guards = new HashSet<String>();
 
 
 
 
 
    public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
        Player player = (Player) sender;
 
 
 
        if (CommandLabel.equalsIgnoreCase("join"));
            if (Assasins.size()== 5);
                if (Guards.size()== 5);
                player.sendMessage(this.PREFIX + ChatColor.RED + "Sorry, the game is full. Please type /spawn, spectate or wait for the next game.");
 
 
                if(Guards.size() == Assasins.size()){
                    Guards.add(player.getName());
                    player.setDisplayName(ChatColor.GOLD + "[" + ChatColor.DARK_AQUA + "Guard" + ChatColor.GOLD + "] " + player.getName());
                    player.sendMessage(this.PREFIX + ChatColor.DARK_AQUA + "You are now a Guard. Pick your Class!");
                }
                    else if(Guards.size() > Assasins.size())
                {
                    Assasins.add(player.getName());
                    player.setDisplayName(ChatColor.GOLD + "[" + ChatColor.DARK_AQUA + "Guard" + ChatColor.GOLD + "] " + player.getName());
                    player.sendMessage(this.PREFIX + ChatColor.RED + "You are now a Assasin. Pick your Class!");
                }
                        else if(Assasins.size() < Guards.size())               
 
                    {
                        Assasins.add(player.getName());
                        player.setDisplayName(ChatColor.GOLD + "[" + ChatColor.DARK_AQUA + "Guard" + ChatColor.GOLD + "] " + player.getName());
                        player.sendMessage(this.PREFIX + ChatColor.RED + "You are now a Assasin. Pick your Class!");
                    }
 
                            return false;
 
    }   
 
 
            private boolean ChangeName(Player target, String name) {
                Team bTeam = this.sbMain.getPlayerTeam(target);
                ((Team) Guards).setPrefix("[Guard]");                   
          return true;
 
            }
 
 
 
 
 
 
 
        }
 
//End of Main Class
 

Here, i'm trying to make it so on the /join command, the player is added to team, Assassin or Guard, they would be added to a team, set a prefix depending on their team, and then i have another class that doesn't allow people on the same team to hit eachother, but i believe you can set the friendly fire off, however, again, i'm not sure, well not so much not sure how, but more so where to put it.

The friendly fire handler is here

Code:java

package me.aperxmc.youtube;
 
import java.util.ArrayList;
import java.util.LinkedList;
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
 
public class FriendlyFireHandler
  implements Listener
 
 
{
 
    private final String PREFIX = ChatColor.DARK_GRAY + "[" + ChatColor.RESET + ChatColor.DARK_RED + ChatColor.BOLD.toString() + "AoA" + ChatColor.RESET + ChatColor.DARK_GRAY + "] "  + ChatColor.RESET;
  @EventHandler(priority=EventPriority.HIGH)
  public void onPlayerHit(EntityDamageByEntityEvent e)
  {
    if (((e.getDamager() instanceof Player)) &&
      ((e.getEntity() instanceof Player))) {
      if ((Maingame.Guards.contains(e.getDamager())) &&
        (Maingame.Guards.contains(e.getEntity()))) {
        Player dmg = (Player)e.getDamager();
        dmg.sendMessage(this.PREFIX +
          ChatColor.RED + "You can't hurt your teammates!");
        e.setCancelled(true);
        return;
      }
 
      if ((Maingame.Assasins.contains(e.getDamager())) &&
        (Maingame.Assasins.contains(e.getEntity()))) {
        Player dmg = (Player)e.getDamager();
        dmg.sendMessage(this.PREFIX +
          ChatColor.RED + "You can't hurt your teammates!");
        e.setCancelled(true);
        return;
      }
 
 
 
      return;
    }
  }
}

That's basically the basis of it. Once i get that all working, the rest of it should be pretty easy, but until then i'm calling on you guys to help a fellow coder out and give me some direction, examples and all.

Any help is muchly appreciated! Thanks
Aperx

 

*Bump*

 

Aperx For the ChangeName method, you never actually 'change' the name. You also might want to put a try/catch block on it to make sure that the name isn't null or the player. If it is then the function has support for returning false when it wasn't successful.

Try formatting your code aswell, it really helps a lot(unless it's already formatted and that is what happened when pasting it to the page).

 

GodzOfMadness So what you're saying is, I've told it what to change their name to, but i haven't actually set it? If this is the case, how do i actually set it?

 

Aperx I'm not sure how this is working but you set the prefix by casting Team to a Set data type. I think you should just get the team the player is on and then just set the prefix by like bTeam.setDisplayName("[Guard]") Which sets the prefix for all players in that team. I don't know about setting their name thought, what are you trying to do there?