Looping through a hashmap

Hi.

I am making a plugin which allows users to have multiple nicknames which cycle around. In order to store this, I am using a Hashmap with <String, ArrayList<String>>. This works fine when the plugin is running, but When I come to save it, I run into problems.

After some Googling, I found out you can loop through a hashmap using

Code:java

for (Entry<String, ArrayList<String>>playernames : playernicknames.entrySet())

Where playernicknames is my current hashmap.

This is my entire for loop:

Code:java

 for (Entry<String, ArrayList<String>>playernames : playernicknames.entrySet()) {
tempnames.clear();
getLogger().info(playernames.getKey());
getLogger().info(String.valueOf(playernames.getValue().size()));
for (String s : playernames.getValue()) {
tempnames.add(s);
}
getLogger().info(String.valueOf(tempnames.size()));
getNicknames().set("Nicknames." + playernames.getKey(), tempnames);
}

As you can see, I have alot of debug messages.

The first time I run the code, it does so perfectly. No matter what i do to it. (I have tried colorCodes, multiple nicknames, multiple players). However, the second time I reload the server, It all breaks.

Here is what happens when I try and run the code the second time:

Code:

[11:52:48] [Server thread/INFO]: [MultiNick] Disabling MultiNick v1.0
[11:52:48] [Server thread/INFO]: [MultiNick] 7e9cbb5e-dda4-40a9-ad4e-40e17466bfa6
[11:52:48] [Server thread/INFO]: [MultiNick] 0
[11:52:48] [Server thread/INFO]: [MultiNick] 0
[11:52:48] [Server thread/INFO]: [MultiNick] MultiNick has been disabled!

Here is what the yml file should look like:
Nicknames:
7e9cbb5e-dda4-40a9-ad4e-40e17466bfa6:
- Toby
- Top
And here is what it looks like after the code breaks it: (Not sure if you need this, though I should put it in anyway)
Nicknames:
7e9cbb5e-dda4-40a9-ad4e-40e17466bfa6: []

The UUID is my UUID, so I know it was actually looping. The zeroes are the size of the loop, both 'tempnames' and 'playernames.getKey()'

However, it should be 2. So why is it doing this?

Thanks for any help received. I understand this is a long post, but I was trying to give you all the relevant information I could.

 

Well, it depends on the rest of your code. We cannot possibly help you with what we have now.

 

TopTobster5
Are you putting the names into the hashmap when the plugin loads?

 

TopTobster5 why are you adding all names to a temp List. Just save the List :3

 

fireblast709 I tried that, I was just fiddling about trying to get something to work.
br456 I am using Player uuids

Rocoty Here is the rest of my code:

Code:java

package me.toptobster5.multinick;
 
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map.Entry;
import java.util.logging.Level;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Multinick extends JavaPlugin implements Listener {
 
public File nicknamesfile;
public FileConfiguration nicknames;
 
public String prefix = ChatColor.BLUE + "[MultiNick] " + ChatColor.DARK_BLUE;
 
public HashMap<String, ArrayList<String>>playernicknames = new HashMap<String, ArrayList<String>>();
public HashMap<String, String>playernicknamescurrent = new HashMap<String, String>();
public List<String> tempnames = new ArrayList<String>();
 
public void reloadNicknames() {
if (nicknamesfile == null) {
nicknamesfile = new File(getDataFolder(), "nicknames.yml");
}
nicknames = YamlConfiguration.loadConfiguration(nicknamesfile);
 
InputStream defConfigStream = this.getResource("nicknames.yml");
if (defConfigStream != null) {
YamlConfiguration defConfig = YamlConfiguration.loadConfiguration(defConfigStream);
nicknames.setDefaults(defConfig);
}
}
 
public FileConfiguration getNicknames() {
if (nicknames == null) {
reloadNicknames();
}
return nicknames;
}
 
public void saveNicknames() {
if (nicknames == null || nicknamesfile == null) {
return;
}
try {
getNicknames().save(nicknamesfile);
} catch (IOException ex) {
getLogger().log(Level.SEVERE, "Could not save config to " + nicknamesfile, ex);
}
}
 
public void saveDefaultNicknames() {
if (nicknamesfile == null) {
nicknamesfile = new File(getDataFolder(), "nicknames.yml");
}
if (!nicknamesfile.exists()) {
getLogger().info("nicknames.yml does not exist, creating a new one!");
this.saveResource("nicknames.yml", false);
}
}
@Override
public void onEnable() {
saveDefaultNicknames();
getServer().getPluginManager().registerEvents(this, this);
try {
for (String key : getNicknames().getConfigurationSection("Nicknames").getKeys(false)) {
tempnames = getNicknames().getStringList("Nicknames." + key);
playernicknames.put(key, (ArrayList<String>) tempnames);
}
} catch (NullPointerException e) {
}
getLogger().info("MultiNick has been enabled!");
}
 
@Override
public void onDisable() {
getNicknames().set("Nicknames", null);
for (Entry<String, ArrayList<String>>playernames : playernicknames.entrySet()) {
tempnames.clear();
getLogger().info(playernames.getKey());
getLogger().info(String.valueOf(playernames.getValue().size()));
for (String s : playernames.getValue()) {
tempnames.add(s);
}
getLogger().info(String.valueOf(tempnames.size()));
getNicknames().set("Nicknames." + playernames.getKey(), tempnames);
}
saveNicknames();
getLogger().info("MultiNick has been disabled!");
}
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
if (label.equalsIgnoreCase("nick")) {
if (args.length > 0) {
if (args[0].equalsIgnoreCase("list")) {
if (args.length == 1) {
if (sender instanceof Player) {
String uuid = ((Player) sender).getUniqueId().toString();
ArrayList<String>n = playernicknames.get(uuid);
sender.sendMessage(prefix + "Your current nicknames:");
try {
for (String s : n) {
sender.sendMessage(s);
}
} catch (NullPointerException e) {
}
return true;
} else {
sender.sendMessage(prefix + "You must be a player to do that!");
return true;
}
} else if (args.length == 2) {
if (sender.hasPermission("multinick.mod") || sender.isOp()) {
for (Player player : Bukkit.getOnlinePlayers()) {
if (player.getName().equalsIgnoreCase(args[1])) {
sender.sendMessage(prefix + player.getName() + " nicknames:");
for (String s : playernicknames.get(player.getUniqueId().toString())) {
sender.sendMessage(s);
}
return true;
}
sender.sendMessage(prefix + "That player is not online!");
return true;
}
} else {
sender.sendMessage(prefix + "You don't have permission to do that!");
return true;
}
} else {
sender.sendMessage(prefix + "Unknown command!");
return true;
}
} else if (args[0].equalsIgnoreCase("add")) {
if (args.length == 2) {
if (sender instanceof Player) {
if (sender.hasPermission("multinick.add") || sender.isOp()) {
String nick = ChatColor.translateAlternateColorCodes('&', args[1]);
try {
playernicknames.get(((Player) sender).getUniqueId().toString()).add(nick);
} catch (NullPointerException e) {
ArrayList<String>m = new ArrayList<String>();
m.add(nick);
playernicknames.put(((Player) sender).getUniqueId().toString(), m);
}
sender.sendMessage(prefix + "Nickname added!");
return true;
} else {
sender.sendMessage(prefix + "You don't have permission to do that!");
return true;
}
} else {
sender.sendMessage(prefix + "You must be a player to do that!");
return true;
}
}
}
} else {
sender.sendMessage(prefix + "Unknown command!");
return true;
}
}
return false;
}
 
 
}
 

 

TopTobster5 I laughed a little. After you put the List in the Map, the next iteration that tempnames still points to the List in the Map, and you clear it. Just removing the tempnames.clear() from the onEnable loop should load them properly.

 

fireblast709 My problem is in the saving part, although I recognize what I did. I have fixed that part, but the plugin still won't save it.

 

TopTobster5 Most likely the same issue. Try it without the use of templist and .clear().