[LIB] GhostFactory - Make players look like ghosts

Try my example here
Source are hosted here.

 

Comphenix
Okay, so this is a general question about the code. Why, in your version of the code, did you exclude the Listener from the Manager? I've never seen, nor have I ever thought of, implementing a Listener with a custom object. I think it's a great idea having the object control it's players by itself and was confused as to why you left it out.

 

I don't think every player should necessarily be added to the ghost team. I could imagine a game where only certain players are able to see the ghosts (ghost busters?), and must assist all the other players that can't.

If the ghost manager added all the players by itself, you would have to either modify it or tell it which players to exclude, either with a a name or a generic predicate. I wanted it to be a drop-in solution, and not force people to modify the manager itself. So I kept the "add player" part outside its scope.

 

Aha.

Maybe an addGhostBuster?

I updated it,

I added ghost buster and auto show support.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Amazing plugin, but tiny issue. I can get this plugin to work to make it so ghosts can see invisible ghosts partly transparent however, I want ghosts to be partly transparent to ALL PLAYERS who can see it. How would I go around doing this? So far, I can see it's not possible.

 

I would use Comphenix 's version

 

This is good for MiniGames THANKS MAN! Like This

 

It still doesn't make ghosts visible to every player on the server, regardless of whether they are ghosts or not.

 

his updated version does. and i edited my post. the current code should work

 

Code:

2013-08-26 15:53:04 [WARNING] [InvisibilityCounter] Task #2 for InvisibilityCounter v1.0 generated an exception
java.lang.NullPointerException
    at com.lenis0012.bukkit.factories.GhostFactory$1.run(GhostFactory.java:76)
    at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftTask.run(CraftTask.java:53)
    at org.bukkit.craftbukkit.v1_6_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:345)
    at net.minecraft.server.v1_6_R2.MinecraftServer.t(MinecraftServer.java:522)
    at net.minecraft.server.v1_6_R2.DedicatedServer.t(DedicatedServer.java:226)
    at net.minecraft.server.v1_6_R2.MinecraftServer.s(MinecraftServer.java:486)
    at net.minecraft.server.v1_6_R2.MinecraftServer.run(MinecraftServer.java:419)
    at net.minecraft.server.v1_6_R2.ThreadServerApplication.run(SourceFile:582)

You should add a null check here.

Code:java

public void run() {
for(String user : players) {
Player player = Bukkit.getPlayer(user);
if(player != null && !player.hasPotionEffect(PotionEffectType.INVISIBILITY))
player.addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, Integer.MAX_VALUE, 15));
}
}

Also I keep getting "End of Stream" while the console is spammed with the exception message. Even when I add the null check I still get "End of Stream"

 

Conarnar you didn't add a proper null check.
replace

Code:

if(player != null && !player.hasPotionEffect(PotionEffectType.INVISIBILITY)){

with

Code:

if(player != null){
  if(!player.hasPotionEffect(PotionEffectType.INVISIBILITY)){

 

Techy4198 Same thing since the double and (&&) only continues checking if the first one returns true.

 

nope. idk who told you that, but it certainly aint true. not in the version of java I have anyway.

 

Techy4198 I have a book on Java.

 

Conarnar how many decades old?

 

Aha, that's exactly what I was using this for (Ghost Busters).

 

It looks like a ghost going on player does not appear
What's wrong with this code?

Code:java

@EventHandler
    public void onPlayerUse(PlayerInteractEvent event){
        Player p = event.getPlayer();
 
        if(p.getItemInHand().getType() == Material.EYE_OF_ENDER){
                p.playEffect(p.getLocation(), Effect.GHAST_SHRIEK, 500000000);
              p.sendMessage (ChatColor.GREEN + "Hayalet Modu Aktif!");
                p.playEffect(p.getLocation(), Effect.MOBSPAWNER_FLAMES, 500000000);
              if(!p.hasPotionEffect(PotionEffectType.INVISIBILITY))
                  p.addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, Integer.MAX_VALUE, 20));
 
                ItemStack item2 = new ItemStack(Material.ENDER_PEARL, 1);
                  PlayerInventory pi = p.getInventory();
                  pi.setItem(1, item2);
                  event.setCancelled(true);
 
 
        }
        else if(p.getItemInHand().getType() == Material.ENDER_PEARL){ 
            p.playEffect(p.getLocation(), Effect.GHAST_SHRIEK, 500000000);
                p.playEffect(p.getLocation(), Effect.MOBSPAWNER_FLAMES, 500000000);
              p.sendMessage (ChatColor.GREEN + "Hayalet Modu Pasif!");
            event.setCancelled(true);
            ItemStack item1 = new ItemStack(Material.EYE_OF_ENDER, 1);
              PlayerInventory pi = p.getInventory();
              pi.setItem(1, item1);
              p.removePotionEffect(PotionEffectType.INVISIBILITY);
        }
    }
 
 

 

Sen bırak bu işleri

 

Just wanted to let you guys know that there's a small mistake in Comphenix' class. The mistake is in the createGetTeam() function: when the team is not nullafter calling "ghostTeam = board.getTeam(GHOST_TEAM_NAME);", in his class the team members won't see other players as ghosts. This is because the line "ghostTeam.setCanSeeFriendlyInvisibles(true);" will not be reached when ghostTeam is not null and the boolean is not set to true by default when the team is created. Anyway, this can be fixed easily, and I've done so in the following class:

Code:java

package me.rprrr.lobby.util.ghostmanager; //Made by Comphenix, based on lenis0012's GhostFactory
 
import java.util.HashSet;
import java.util.Iterator;
import java.util.Set;
 
import org.bukkit.Bukkit;
import org.bukkit.OfflinePlayer;
import org.bukkit.entity.Player;
import org.bukkit.plugin.Plugin;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
import org.bukkit.scheduler.BukkitTask;
import org.bukkit.scoreboard.Scoreboard;
import org.bukkit.scoreboard.Team;
 
public class GhostManager {
    /**
    * Team of ghosts and people who can see ghosts.
    */
    private static final String GHOST_TEAM_NAME = "Ghosts";
    private static final long UPDATE_DELAY = 20L;
 
    // No players in the ghost factory
    private static final OfflinePlayer[] EMPTY_PLAYERS = new OfflinePlayer[0];
    private Team ghostTeam;
 
    // Task that must be cleaned up
    private BukkitTask task;
    private boolean closed;
 
    // Players that are actually ghosts
    private Set<String> ghosts = new HashSet<String>();
 
    public GhostManager(Plugin plugin) {
        // Initialize
        createTask(plugin);
        createGetTeam();
    }
 
    private void createGetTeam() {
        Scoreboard board = Bukkit.getServer().getScoreboardManager().getMainScoreboard();
 
        ghostTeam = board.getTeam(GHOST_TEAM_NAME);
 
        // Create a new ghost team if needed
        if (ghostTeam == null) {
            ghostTeam = board.registerNewTeam(GHOST_TEAM_NAME);
            //The line used to be here...
        }
 
        ghostTeam.setCanSeeFriendlyInvisibles(true); //...and here's where I (Rprrr) put it.
    }
 
    private void createTask(Plugin plugin) {
        task = Bukkit.getScheduler().runTaskTimer(plugin, new Runnable() {
            @Override
            public void run() {
                for (OfflinePlayer member : getMembers()) {
                    Player player = member.getPlayer();
 
                    if (player != null) {
                        // Update invisibility effect
                        setGhost(player, isGhost(player));
                    } else {
                        ghosts.remove(member.getName());
                        ghostTeam.removePlayer(member);
                    }
                }
            }
        }, UPDATE_DELAY, UPDATE_DELAY);
    }
 
    /**
    * Remove all existing player members and ghosts.
    */
    public void clearMembers() {
        if (ghostTeam != null) {
            for (OfflinePlayer player : getMembers()) {
                ghostTeam.removePlayer(player);
            }
        }
    }
 
    /**
    * Add the given player to this ghost manager. This ensures that it can see ghosts, and later become one.
    * @param player - the player to add to the ghost manager.
    */
    public void addPlayer(Player player) {
        validateState();
        if (!ghostTeam.hasPlayer(player)) {
            ghostTeam.addPlayer(player);
            //player.addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, Integer.MAX_VALUE, 15));
        }
    }
 
    /**
    * Determine if the given player is tracked by this ghost manager and is a ghost.
    * @param player - the player to test.
    * @return TRUE if it is, FALSE otherwise.
    */
    public boolean isGhost(Player player) {
        return player != null && hasPlayer(player) && ghosts.contains(player.getName());
    }
 
    /**
    * Determine if the current player is tracked by this ghost manager, or is a ghost.
    * @param player - the player to check.
    * @return TRUE if it is, FALSE otherwise.
    */
    public boolean hasPlayer(Player player) {
        validateState();
        return ghostTeam.hasPlayer(player);
    }
 
    /**
    * Set wheter or not a given player is a ghost.
    * @param player - the player to set as a ghost.
    * @param isGhost - TRUE to make the given player into a ghost, FALSE otherwise.
    */
    public void setGhost(Player player, boolean isGhost) {
        // Make sure the player is tracked by this manager
        if (!hasPlayer(player))
            addPlayer(player);
 
        if (isGhost) {
            ghosts.add(player.getName());
            player.addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, Integer.MAX_VALUE, 15));
        } else if (!isGhost) {
            ghosts.remove(player.getName());
            player.removePotionEffect(PotionEffectType.INVISIBILITY);
        }
    }
 
    /**
    * Remove the given player from the manager, turning it back into the living and making it unable to see ghosts.
    * @param player - the player to remove from the ghost manager.
    */
    public void removePlayer(Player player) {
        validateState();
        if (ghostTeam.removePlayer(player)) {
            player.removePotionEffect(PotionEffectType.INVISIBILITY);
        }
    }
 
    /**
    * Retrieve every ghost currently tracked by this manager.
    * @return Every tracked ghost.
    */
    public OfflinePlayer[] getGhosts() {
        validateState();
        Set<OfflinePlayer> players = new HashSet<OfflinePlayer>(ghostTeam.getPlayers());
 
        // Remove all non-ghost players
        for (Iterator<OfflinePlayer> it = players.iterator(); it.hasNext(); ) {
            if (!ghosts.contains(it.next().getName())) {
                it.remove();
            }
        }
        return toArray(players);
    }
 
    /**
    * Retrieve every ghost and every player that can see ghosts.
    * @return Every ghost or every observer.
    */
    public OfflinePlayer[] getMembers() {
        validateState();
        return toArray(ghostTeam.getPlayers());
    }
 
    private OfflinePlayer[] toArray(Set<OfflinePlayer> players) {
        if (players != null) {
            return players.toArray(new OfflinePlayer[0]);
        } else {
            return EMPTY_PLAYERS;
        }
    }
 
    public void close() {
        if (!closed) {
            task.cancel();
            ghostTeam.unregister();
            closed = true;
        }
    }
 
    public boolean isClosed() {
        return closed;
    }
 
    private void validateState() {
        if (closed) {
            throw new IllegalStateException("Ghost factory has closed. Cannot reuse instances.");
        }
    }
}

 

Ah, thanks for fixing that bug.

I've updated my version on GitHub to include your fix.

 

Comphenix
Thank you!

 

Comphenix mind if i put a link to your version on this post?

 

Sure, go ahead.

 

yooo örenip baskalarina anlatacam
bilmemek ayip deildir örenmemek ayiptir...

 

Sen direk potion effect vermissin olay bu degil

 

biliyorum daha önce direk potion effect vererek kendimi yari görunur yapmistim fakat sonra tekrar deneyince olmamisti cok garibime gitti buda neyse bu öretici konuyu bos verdim su an işime yaramiyo istesem yaparim kisaca urasmiycam

 

This is most likely not working on 1.7
I still need to edit the post to use Comphenix's version.

 

Hello all.
i gave this a quick try but it makes the player invisible and you cant see him.
nobody can see him.

My classes here \/

main:

Code:java

package nl.MD5Dev.Ghost;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
public GhostFactory ghostFactory;
 
@Override
public void onEnable(){
this.ghostFactory = new GhostFactory(this, true);
ghostFactory.create();
}
 
@Override
public void onDisable(){
 
}
 
@Override
public boolean onCommand(CommandSender sender, Command cmd,
String commandLabel, String[] args) {
Player player = (Player) sender;
if (commandLabel.equalsIgnoreCase("ghostmode")){
if (args[0].equalsIgnoreCase("enable")){
player.sendMessage(ChatColor.GREEN + "You are now a ghost!");
ghostFactory.addGhost(player);
} else if (args[0].equalsIgnoreCase("disable")){
ghostFactory.removeGhost(player);
} else {
player.sendMessage(ChatColor.RED + "Invalid arguments, use the command like this:");
player.sendMessage(ChatColor.RED + "/GhostMode <enable:disable>");
}
}
return true;
 
}
}
 

GhostFactory:

Code:java

package nl.MD5Dev.Ghost;
 
import java.lang.reflect.Field;
import java.lang.reflect.Method;
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerQuitEvent;
import org.bukkit.plugin.Plugin;
import org.bukkit.plugin.PluginManager;
import org.bukkit.potion.PotionEffect;
import org.bukkit.potion.PotionEffectType;
 
/**
* GhostFactory
* Make players look like ghosts
*
* Requirements:
* - MC 1.5+
*
* @author lenis0012
*/
public class GhostFactory {
private static final String MC_VERSION;
 
static {
String version = "";
if(!checkVersion(version)) {
StringBuilder builder = new StringBuilder();
for(int a = 0; a < 10; a++) {
for(int b = 0; b < 10; b++) {
for(int c = 0; c < 10; c++) {
builder.setLength(0);
builder.append('v').append(a).append('_').append(b).append("_R").append(c).append('.');
version = builder.toString();
if(checkVersion(version))
a = b = c = 10;
}
}
}
}
 
MC_VERSION = version;
}
 
private static final String NMS_ROOT = "net.minecraft.server." + MC_VERSION;
 
private static boolean checkVersion(String version) {
try {
Class.forName("net.minecraft.server." + version + "World");
return true;
} catch (ClassNotFoundException e) {
return false;
}
}
 
private List<String> players = new ArrayList<String>();
private boolean created = false;
private boolean show;
 
public GhostFactory(Plugin plugin, boolean show) {
this.show = show;
PluginManager pm = Bukkit.getPluginManager();
pm.registerEvents(new GhostListener(this), plugin);
Bukkit.getScheduler().runTaskTimer(plugin, new Runnable() {
@Override
public void run() {
for(String user : players) {
Player player = Bukkit.getPlayer(user);
if(!player.hasPotionEffect(PotionEffectType.INVISIBILITY))
player.addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, Integer.MAX_VALUE, 15));
}
}
}, 5L, 5L);
}
 
public void create() {
if(created)
return;
 
this.update(0);
this.created = true;
}
 
public void remove() {
if(!created)
return;
 
this.update(1);
this.created = false;
}
 
public boolean isCreated() {
return this.created;
}
 
public void addGhost(Player player) {
if(!show)
this.addGhostBuster(player);
player.addPotionEffect(new PotionEffect(PotionEffectType.INVISIBILITY, Integer.MAX_VALUE, 15));
}
 
public void removeGhost(Player player) {
if(!show)
this.removeGhostBuster(player);
player.removePotionEffect(PotionEffectType.INVISIBILITY);
}
 
public boolean addGhostBuster(Player player) {
if(players.add(player.getName())) {
this.update(3);
return true;
} else
return false;
}
 
public boolean removeGhostBuster(Player player) {
if(players.remove(player.getName())) {
this.update(4);
return true;
} else
return false;
}
 
public boolean isGhostBuster(Player player) {
return players.contains(player.getName());
}
 
public boolean isGhost(Player player) {
return player.hasPotionEffect(PotionEffectType.INVISIBILITY);
}
 
public String[] getGhostBusters() {
return players.toArray(new String[0]);
}
 
public void clearGhostBusters() {
players.clear();
}
 
private void update(int action) {
Object packet = this.createPacket("Packet209SetScoreboardTeam");
this.setValue(packet, "a", "ghosts");
this.setValue(packet, "f", action);
this.setValue(packet, "b", "Ghosts");
this.setValue(packet, "c", "");
this.setValue(packet, "d", "");
this.setValue(packet, "g", 2);
this.setValue(packet, "e", players);
 
for(Player player : Bukkit.getOnlinePlayers()) {
this.sendPacket(player, packet);
}
}
 
private void sendTo(Player player) {
Object packet = this.createPacket("Packet209SetScoreboardTeam");
this.setValue(packet, "a", "ghosts");
this.setValue(packet, "f", 0);
this.setValue(packet, "b", "Ghosts");
this.setValue(packet, "c", "");
this.setValue(packet, "d", "");
this.setValue(packet, "g", 2);
this.setValue(packet, "e", players);
this.sendPacket(player, packet);
}
 
private void setValue(Object instance, String fieldName, Object value) {
try {
Field field = instance.getClass().getDeclaredField(fieldName);
field.setAccessible(true);
field.set(instance, value);
} catch(Exception e) {
e.printStackTrace();
}
}
 
private Object getValue(Object instance, String fieldName) {
try {
Field field = instance.getClass().getDeclaredField(fieldName);
field.setAccessible(true);
return field.get(instance);
} catch(Exception e) {
e.printStackTrace();
return null;
}
}
 
private Object invoke(Object instance, String methodName, Class<?>[] fields, Object[] values) {
try {
Method method = instance.getClass().getDeclaredMethod(methodName, fields);
method.setAccessible(true);
return method.invoke(instance, values);
} catch(Exception e) {
e.printStackTrace();
return null;
}
}
 
private Object createPacket(String name) {
try {
Class<?> clazz = Class.forName(NMS_ROOT + name);
return clazz.newInstance();
} catch(Exception e) {
e.printStackTrace();
return null;
}
}
 
private void sendPacket(Player player, Object packet) {
try {
Class<?> Packet = Class.forName(NMS_ROOT + "Packet");
Object playerHandle = this.invoke(player, "getHandle", new Class<?>[0], new Class<?>[0]);
Object playerConnection = this.getValue(playerHandle, "playerConnection");
this.invoke(playerConnection, "sendPacket", new Class<?>[] {Packet}, new Object[] {packet});
} catch(Exception e) {
e.printStackTrace();
}
}
 
public static class GhostListener implements Listener {
private GhostFactory factory;
 
public GhostListener(GhostFactory factory) {
this.factory = factory;
}
 
@EventHandler(priority = EventPriority.MONITOR)
public void onPlayerQuit(PlayerQuitEvent event) {
Player player = event.getPlayer();
factory.removeGhost(player);
if(factory.show)
factory.removeGhostBuster(player);
}
 
@EventHandler(priority = EventPriority.LOWEST)
public void onPlayerJoin(PlayerJoinEvent event) {
Player player = event.getPlayer();
factory.sendTo(player);
if(factory.show)
factory.addGhostBuster(player);
}
}
}

Plugin.yml:

Code:

main: nl.MD5Dev.Ghost.Main
version: 1.0
name: Ghost
author: MD5Dev
commands:
  GhostMode:
    description: Toggles GhostMode
    usage: /GhostMode <Enable:Disable>

anybody know what i did wrong?


EDIT: Nvm, i ran it on 1.7.2, works on 1.6.4

 

lenis0012 The Comphenix 's version is incompatible with ScoreboardStats (I do not why) :/

 

Many scoreboard plugins are incompatible, and this is an unfortunate consequence of how Dinnerbone implemented the scoreboard systen. A player can only be a member of a single team, and certain features (such as the ghost invisibility effect), require that two players are a member of the same team.

This limitation is inherent in the client-side implementation of the scoreboard system, and cannot be changed in Bukkit alone. I suggest disabling ScoreboardStats for the duration of the game that requires GhostFactory, or perhaps use a different method for displaying that information:

• Display the information as client-side blocks in the sky.
• Use DragonAnnouncer.
• Show the statistics in the chat withour disrupting normal conversation. I suggest either dividing the chat into two columns (left would be chat, right would be statistics), or two rows (top and bottom). I don't know if this is possible with pure Bukkit API, but I definitely know it can be done with ProtocolLib.
• Draw it in a map.
• Etc. Use your imagination.