Solved Lag problem

Hi there I am making a plugin for a server with tons of people on every day It does use multiverse and the owner wanted me to work on the scoreboards for it. So I'm also going to give him a per world tablist and per player scoreboards and teams. But the problem is that I don't know how to apply it on join. I was thinking
for (Player p : Bukkit.getOnlinePlayers()) {
if (p.getWorld() == e.getPlayer().getWorld()) {
//do stuff
}else{
p.hidePlayer(e.getPlayer));
e.getPlayer().hidePlayer(P)):
But the problem is that if this is a server with so many people joining all the time won't these for statements lag out the server? If it does lag it out a lot can someone give me another way thanks!

 

CaptainUniverse ,
Yes, that will likely cause some lag with a large server. I would try to see if it does first, and if it does, I would change it to check for players on the spawn point of each world instead.

 

how would you check on the spawn point of each world Tecno_Wizard?

 

CaptainUniverse, Great question. I have no idea. Let me look, XD

UPDATE: I think the best way to do it would be to check whether the player onJoin is in the spawn location, and update as necessary depending on the player's location.

 

Bump

 

CaptainUniverse Have you actually done any debug that shows that these statements "lag" the server?

 

Imo, it shouldnt have any noticeable lag. Unless //do stuff is heavy. They rest is not so heavy for an onjoin event (it doesnt happen as often as you think, unlike a loop every tick).

 

CaptainUniverse no need to hide players which are in different worlds, is there now

 

fireblast709 what do you mean? I mean his server s big with minigames the tablist will be too crowded and it will be more efficient for the players playing the minigames.

and BillyGalbreath But my frineds server is getting big he might have people joining and leaving every second wouldn't that cause lag?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Not necessarily, no. If a player joins every second, you still have 19 cycles (ticks) in between that are idle (20 ticks per second).

Edit: Now, if you have a piece of code that makes that single cycle (tick) lag, then you dont have a problem on large servers, you have a problem on ALL servers, big and small.

 

Thanks BillyGalbreath and everyone else for the help