JSON and PlayerChatEvent Help!

So i am making a plugin where when a player talks it adds a prefix to their chat and when you click it it takes you to a site.
This is what i got:

Code:

    public void chatClickable1(Player p, String link1, String link2, String message) {
        String url = link1+p.getName()+link2;
        IChatBaseComponent comp = ChatSerializer.a("{\"text\":\"[L]\",\"hoverEvent\":{\"action\":\"show_text\",\"value\":\"Open player's panel\"},\"clickEvent\":{\"action\":\"open_url\",\"value\":\""+url+"\"},\"extra\":[{\"text\":\""+message+"\"}]}");
        PacketPlayOutChat packet = new PacketPlayOutChat(comp);
        ((CraftPlayer) p).getHandle().playerConnection.sendPacket(packet);
    }

For the JSON method.
This is how i use it:

Code:

               event.setCancelled(true);
                String message2 = (event.getPlayer().getDisplayName() + ChatColor.GRAY + ": " + ChatColor.WHITE + event.getMessage());

                for (Player p : Bukkit.getServer().getOnlinePlayers()) {
                    if (p.hasPermission("staff")) {
                        chatClickable1(p, link1, link2, message2);
                    } else {
                        p.sendMessage(message2);
                    }
                }

Now it works, but every time i send a message with MORE than 1 word it sends it the amount of words i have in it. This is a huge problem for me.
If anyone can help it would be very appreciated!

~ dlange

 

What do you mean it sends the amount of words? That it sends the message for each word you have entered, the amount of words in an int value or something else?

 

@megamichiel say i typed: "Hello i am dlange", that sentence has 4 words, so it sends the message 4 times

 

@dlange
This part of code looks fine, would you mind showing the whole method?

 

@dlange Watch out with what you are doing here, if a user sends a message with " then it will mess up your JSON format and therefore cause an exception to be thrown. You need to escape the message if you want to get rid of that problem. This method would do the trick: https://github.com/NLthijs48/FancyM...mat/src/FancyMessageFormatConverter.java#L301

 

@megamichiel Sure -

Code:

    public void chatClickable1(Player p, String link1, String link2, String message) {
        String url = link1+p.getName()+link2;
        IChatBaseComponent comp = ChatSerializer.a("{\"text\":\"[L] \",\"hoverEvent\":{\"action\":\"show_text\",\"value\":\"Open player's ban panel\"},\"clickEvent\":{\"action\":\"open_url\",\"value\":\""+url+"\"},\"extra\":[{\"text\":\""+message+"\"}]}");
        PacketPlayOutChat packet = new PacketPlayOutChat(comp);
        ((CraftPlayer) p).getHandle().playerConnection.sendPacket(packet);
    }

and this is how i use it in PlayerChatEvent -

Code:

            {
                event.setCancelled(true);
                String link1 = "privateurl1";
                String link2 = "privateurl2";
                String message2 = (event.getPlayer().getDisplayName() + ChatColor.GRAY + ": " + ChatColor.WHITE + event.getMessage());

                for (Player p : Bukkit.getServer().getOnlinePlayers()) {
                    if (p.hasPermission("orchestra.staff")) {
                        chatClickable1(p, link1, link2, message2);
                    } else {
                        p.sendMessage(message2);
                    }
                }
            }

And @nlthijs48 ill try that thanks

EDIT: @nlthijs48 can you explain how i would use that?

 

@dlange
The code should be fine, I can't find anything that is wrong.
About what nlthijs48 said, you can just copy the method inside FancyMessageFormatConverter to your class, and then use instead of calling e.getMessage() use quoteStringJson(e.getMessage())

 

@megamichiel Ah ok thanks i will try this!

@megamichiel That didn't work, but i messed around a bit and found the problem, this line:

Code:

        IChatBaseComponent comp = ChatSerializer.a("{\"text\":\"[L] \",\"hoverEvent\":{\"action\":\"show_text\",\"value\":\"View player's table\"},\"clickEvent\":{\"action\":\"open_url\",\"value\":\""+url+"\"}}");

BUT when i add the 'message' string to the end it doesn't work. How would i add another text area after that with an already defined string?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bump!

 

@dlange Do you get a stacktrace when you try to use it? Because that might be very useful to post here. It might be helpful to first create the tellraw string you need with a tool like minecraftjson.com with simply some placeholder text values in it, and after that change it for use in your code (escape special characters, replace placeholders with correct values).