HashMap help - "Requesting something"

Hey, I needed some help with my 1v1 plugin I was making. In order to make it have somewhat of a "request", I thought a good way to do it would be by using a HashMap. For example, when you right click a player, if he hasn't already requested a 1v1, you put them in a HashMap. That's all quick and easy, but what I'm having trouble with is if they did request a 1v1. I'll give some of my code to see what I'm talking about.

Code:java

HashMap<Player, Player> request = new HashMap<Player, Player>();
 
 
if (p.getItemInHand().getType() == Material.STICK
                    && p.getItemInHand().getItemMeta().getDisplayName()
                            .equalsIgnoreCase(ChatColor.stripColor("1v1"))) {
                if(request.containsValue(p)) {
 
                                }
                // How to check if they are already in the hashmap?
            }

So, I just need a way to check if they already have right clicked him. Any ideas?

 

Googlelover1234
You already checked if they are in the hashmap by using request.containsValue(p)

 

Umm this is off-topic, but I heard that it isn't good to use players when making arraylists and maps. i think you should use player's names. but i might be wrong

 

EgyptianKing It isn't a good idea to put players in the lists because they could cause memory leaks when the player leaves. The garbage collector can't garbage collect the player because it is still being used by the list. You could remove the player from the list when he leaves but it'll be better to just stick with UUID or player names. It would be preferred to use UUID but you could use player names if it is just a one session thing. But it'll be better to get in the habit of using UUID.

Googlelover1234 Since you are using Player as the key and the value, it'll be better to stick to using an arraylist.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

teej107
He wants to associate another player with some other player for 1v1. A List wouldn't do such things.

 

Gater12 Ah I see now. I thought he was using the same player for the key and value. my error

 

Use a BidiMap.

 

EgyptianKing Okay, I'll note that :3
AoH_Ruthless Okay, so should I just check if "ent" is in the HashMap?

So here's what I'm trying to do. When a person right clicks them with a stick or something, it'll put them in a HashMap, and if a player right clicks someone that already has asked them, they start a 1v1. What I need help with is checking if the person a player right clicks is already in a HashMap with them.

 

Bump

 

Code:java

HashMap<Player, Player> request = new HashMap<Player, Player>();
 
Player p = event.getPlayer();
Player B //whatever code you have for the player being clicked
if (p.getItemInHand().getType() == Material.STICK && p.getItemInHand().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.stripColor("1v1"))) {
if(request.containsKey(p) && request.containsValue(PLAYER B)) {
//already in
}else{
request.put(p, PLAYER B);
}
}