Creating a custom creative InventoryView

I am making a technology plugin in which I need players to choose items. I was going to do this using a Creative Inventory.

How could I create a Custom Creative InventoryView which uses a filled Creative Inventory view for the top and a small inventory on the bottom. I don't want the bottom Inventory to be the players Inventory. Here is what I have so far:

Code:java

public class SelectorInventoryView extends InventoryView{
 
    private Inventory top, bottom;
    private Player player;
 
    public SelectorInventoryView(Player player){
        this.player = player;
        this.top = Bukkit.createInventory(player, InventoryType.CREATIVE);
        this.bottom = Bukkit.createInventory(player, 9);
        this.bottom.setMaxStackSize(1);
    }
 
    @Override
    public Inventory getBottomInventory() {
        return bottom;
    }
 
    @Override
    public HumanEntity getPlayer() {
        return player;
    }
 
    @Override
    public Inventory getTopInventory() {
        return top;
    }
 
    @Override
    public InventoryType getType() {
        return InventoryType.CREATIVE;
    }
 
}

Any help would be appreciated

 

chrisXgames AFAIK You can't edit the creative inventory, nor are you able to (properly) create it server-side
See http://jd.bukkit.org/rb/apidocs/org/bukkit/event/inventory/InventoryType.html#CREATIVE
You could just use another Inventory such as a chest

 

Thank you for that information. But how could I create a item selector using what I have server-side? Cause I don't think I can make Chests bigger than 54.

 

chrisXgames Could implement a "Page" system, where you have ItemStacks to go forward and back a page, then utilize this to spread the items across multiple chest inventories.

 

That is great advice. Is it possible to get all Items and all valid MaterialData for that Item?

 

chrisXgames You can loop through Material's values and create a new ItemStack for each Material.
Also: http://jd.bukkit.org/rb/apidocs/org/bukkit/Material.html#getData() able to get MaterialData's class and:
http://jd.bukkit.org/rb/apidocs/org/bukkit/Material.html#getNewData(byte) able to create a new MaterialData from said Material.

 

But that method is Deprecated due to magic value.

 

chrisXgames Deprecated doesn't mean broken. Though, you could create new instances of the MaterialData class (and its subclasases) using the getData() method and calling newInstance() on it (or create a method to pair the class with a new MaterialData object). Though, that 2nd thing is all getNewData() does, except with the deprecated data value.

 

Now I get a lengthy error.

[14:03:20] [Server thread/ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'tech' in plugin TechCraft v0.1
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:180) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at org.bukkit.craftbukkit.v1_7_R3.CraftServer.dispatchCommand(CraftServer.java:701) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.PlayerConnection.handleCommand(PlayerConnection.java:956) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.PlayerConnection.a(PlayerConnection.java:817) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.PacketPlayInChat.a(PacketPlayInChat.java:28) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.PacketPlayInChat.handle(PacketPlayInChat.java:47) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.NetworkManager.a(NetworkManager.java:157) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.ServerConnection.c(SourceFile:134) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:667) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.DedicatedServer.v(DedicatedServer.java:260) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.MinecraftServer.u(MinecraftServer.java:558) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.MinecraftServer.run(MinecraftServer.java:469) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.ThreadServerApplication.run(SourceFile:628) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
Caused by: java.lang.ArrayIndexOutOfBoundsException: 27
at org.bukkit.craftbukkit.v1_7_R3.inventory.CraftInventoryCustom$MinecraftInventory.getItem(CraftInventoryCustom.java:70) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.Slot.getItem(Slot.java:43) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.Container.a(Container.java:66) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.Container.addSlotListener(Container.java:57) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at org.bukkit.craftbukkit.v1_7_R3.entity.CraftHumanEntity.openInventory(CraftHumanEntity.java:319) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at us.chrisix.techcraft.core.selector.Selector.open(Selector.java:21) ~[?:?]
at us.chrisix.techcraft.TechCraft.onCommand(TechCraft.java:45) ~[?:?]
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
... 13 more
[14:03:20] [Server thread/ERROR]: Encountered an unexpected exception
net.minecraft.server.v1_7_R3.ReportedException: Ticking entity
at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:653) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.DedicatedServer.v(DedicatedServer.java:260) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.MinecraftServer.u(MinecraftServer.java:558) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.MinecraftServer.run(MinecraftServer.java:469) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.ThreadServerApplication.run(SourceFile:628) [craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
Caused by: java.lang.ArrayIndexOutOfBoundsException: 27
at org.bukkit.craftbukkit.v1_7_R3.inventory.CraftInventoryCustom$MinecraftInventory.getItem(CraftInventoryCustom.java:70) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.Slot.getItem(Slot.java:43) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.Container.b(Container.java:74) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.EntityPlayer.h(EntityPlayer.java:175) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.World.entityJoinedWorld(World.java:1421) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.World.playerJoinedWorld(World.java:1402) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.World.tickEntities(World.java:1290) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.WorldServer.tickEntities(WorldServer.java:481) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
at net.minecraft.server.v1_7_R3.MinecraftServer.v(MinecraftServer.java:649) ~[craftbukkit.jar:git-Bukkit-1.7.9-R0.1-10-g8688bd4-b3092jnks]
...

The line of code us.chrisix.techcraft.core.selector.Selector.open(Selector.java:21) is when the player opens my custom inventory view.

Custom Inventory View

Code:java

public class SelectorInventoryView extends InventoryView{
 
private Selector selector;
private int tab;
private Inventory inventory;
 
public SelectorInventoryView(Selector selector, int tab){
this.selector = selector;
this.tab = tab;
this.inventory = selector.getTabs()[tab].toInventory(selector.getPlayer());
}
 
public SelectorInventoryView next(){
if(tab + 1 == selector.getTabs().length){
return null;
}
else{
return new SelectorInventoryView(selector, tab + 1);
}
}
 
@Override
public Inventory getBottomInventory() {
return selector.getSelected();
}
 
@Override
public HumanEntity getPlayer() {
return selector.getPlayer();
}
 
@Override
public Inventory getTopInventory() {
return inventory;
}
 
@Override
public InventoryType getType() {
return InventoryType.CHEST;
}
 
}

Selector Class

Code:java

public class Selector {
 
private Player player;
private Tab[] tabs;
private Inventory selected;
 
public Selector(Player player, Tab[] tabs){
this.player = player;
this.tabs = tabs;
this.selected = Bukkit.createInventory(player, 27);
}
 
public void open(){
SelectorInventoryView view = new SelectorInventoryView(this, 0);
player.openInventory(view);
}
 
// Getters
public Player getPlayer(){ return player; }
public Tab[] getTabs(){ return tabs; }
public Inventory getSelected(){ return selected; }
 
}

 

chrisXgames Why are you extending InventoryView? Not sure as to what made you decide this, but you should note http://jd.bukkit.org/rb/doxygen/d2/df5/classorg_1_1bukkit_1_1inventory_1_1InventoryView.html#details .
I am guessing something you've done doesn't "satisfy the expected contracts of certain methods", or is a simple error. Can you provide the part where you actually create the instance (I am guessing it is in onCommand())?

 

I've created InventoryViews in the past for some of my other plugins. So I thought it would be simple to just create my own inventory view to show the tab items on top, and the selected items on the bottom. But what really happens is that the player inventory is on the bottom and throws the error. I looked at what needs to be part of the InventoryView before and I can't find that I'm doing anything wrong.

What other way would there be to achieve what I want to happen?

onCommand Code.

Code:java

    public boolean onCommand(CommandSender sender, Command command, String label, String args[]){
        if(sender instanceof Player && command.getName().equalsIgnoreCase("tech")){
            Player player = (Player) sender;
            if(args[0].equalsIgnoreCase("seltest")){
                Selector select = new Selector(player, new Tab[]{
                        new Tab("test", new ItemStack[]{
                                new ItemStack(Material.WOOD)
                                } )
                        } );
 
                select.open();
            }
        }
        return false;
    }

 

chrisXgames Ah, I see what you are trying to do. Give me a few min., Ill do some testing to see how to accomplish this.
May I see this method?:

Code:

selector.getTabs()[tab].toInventory(selector.getPlayer());

 

Here is my Tab class.

Code:java

public class Tab {
 
private String name;
private ItemStack[] context;
 
public Tab(String name, ItemStack[] context){
this.name = name;
this.context = context;
}
 
public Inventory toInventory(){
Inventory inv = Bukkit.createInventory(null, 54);
for(int i = 0; i < context.length && i < 54; i++){
inv.setItem(i, context);
}
 
return inv;
}
 
public String getName(){ return name; }
 
public ItemStack[] getContext(){
return context;
}
 
}

Thanks for helping me out with this

 

chrisXgames The InventoryViews you've made in the past, did those work properly? If so, may you show some of them? From the testing i've done, it seems to "break" the connection of the Player, kicking them, but assuming they are still online on the server (as the warning on InventoryView suggested) From what I've gathered, the InventoryView's getType() may be causing the problem. It may be that the client (or server) doesn't know how to handle the InventoryView. Further testing, I was able to open a "proper" inventory view (Chest up top, Player inventory at bottom), it threw many errors with clicks and was generally buggy. It may just be that there isn't much support for custom InventoryViews in Bukkit.

 

My other InventoryViews had the proper way, Chest on Top and Player on the bottom. They didn't work with Shift-Clicks very well. But the rest worked fine. So yes there might not be support for a such a view that I am looking for.

Did you have another idea on how I could go through tabs and select Items?

 

chrisXgames Use just a regular Inventory (54 size), structured something like:

Code:

<------->
xxxxxxxxx
xxxxxxxxx
xxxxxxxxx
xxxxxxxxx
---------

Where < is Back a page (if at page one, either isn't there, sends to last page, or whatever you want), > is Next page (similar to what happens at page one, except with the last page either leading to first or just not being there), - being a filler item to represent a blank slot (could be air, or something like black stained glass, piston head, etc), and x being your ItemStack's.
Could mess around with this style, and create something you'd like.

As for InventoryViews, they seem buggy when you try and create your own custom views. Drag clicks break, Internal server errors, etc.

 

How could I implement that? I was thinking that using Commands was too complicated. And I believe there is no way to create custom buttons.

 

chrisXgames Simply use Bukkit#createInventory() to make the 54-slot inventory, and have each of the "buttons" be an ItemStack of specific type and metadata, such as making the "Back" Red Stained Glass with the name "&cBack", then use listeners for the various events fired involving Inventories.

 

Ohh, I was just going to have them go through each tab. But that way works better Thank you for all your help.