Can't update config file

Having trouble with this, keeps saying 0 zombies and not updating after I kill one? Also not getting a /mobmine/config.yml file when running the server.

Code:

Code:java

package me.wh1ld.mobmine;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.entity.Zombie;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDeathEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class MobMine extends JavaPlugin implements Listener {
 
    public void OnDisable() {
        saveConfig();
    }
 
    public void OnEnable() {
        this.getConfig().options().copyDefaults(true);
        saveConfig();
    }
 
    @EventHandler(priority = EventPriority.HIGHEST)
    public void KillZombie(EntityDeathEvent e) {
 
        //Killed Entity
        Entity deadEntity = e.getEntity();
        //Who killed the Entity
        Entity sender = e.getEntity().getKiller();
 
        if (sender instanceof Player && deadEntity instanceof Zombie) {
 
            Player player = (Player) sender;
 
            int zkillcount = getConfig().getInt("zombieskilled");
            int zkillworth = getConfig().getInt("zombieskilledworth");
            getConfig().set("zombieskilled", zkillcount + 1);
            player.sendMessage(ChatColor.DARK_GREEN + "Zombie Killed! " + zkillworth + ChatColor.GOLD + "Added to your balance.");
        }
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
        Player player = (Player) sender;
        if(commandLabel.equalsIgnoreCase("zombiemine")) {
            player.sendMessage(ChatColor.GOLD + "" + this.getConfig().getInt("zombieskilled") + ChatColor.DARK_GREEN + " Zombies" + ChatColor.GOLD + " killed in total.");
        }
    return false;
    }
 
}
 

 

At the moment you're only saving the configuration file when you're unloading the plugin. This is bad for two reasons:

• You have to save it after modifying it, because otherwise you're not getting the proper return when you're requesting it.
• When you modify the config YAML, and then reload the server, it'll override your modifications with the original file, meaning you lose your modifications.

FIX:

• Remove the saveConfig() from the onDisable()
• Add the saveConfig() below the getConfig().set();

 

wh1ld onEnable and on disable, not OnEnable or OnDisable. Also you haven't registered your events. Moreover you didn't check if sender instanceof Player, which would throw an error if the console would execute the command. Lastly rather use cmd.getName() for alias support

 

TheMcScavenger wh1ld

Untrue, config values are stored in memory, saving it everytime its modified is just unneeded io. Should save it every-so-often, like every 30min to prevent data loss.

That is why most plugins implement a 'reload' feature for their configs, to "reload" the data stored in memory.

 

Okay, I've done as you said. New code:

Code:java

package me.wh1ld.mobmine;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Entity;
import org.bukkit.entity.Player;
import org.bukkit.entity.Zombie;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDeathEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class MobMine extends JavaPlugin implements Listener {
 
public void onDisable() {
//Disabled
}
 
public void onEnable() {
this.getConfig().options().copyDefaults(true);
saveConfig();
}
 
@EventHandler(priority = EventPriority.HIGHEST)
public void KillZombie(EntityDeathEvent e) {
 
//Killed Entity
Entity deadEntity = e.getEntity();
//Who killed the Entity
Entity sender = e.getEntity().getKiller();
 
if (sender instanceof Player && deadEntity instanceof Zombie) {
 
Player player = (Player) sender;
 
int zkillcount = getConfig().getInt("zombieskilled");
int zkillworth = getConfig().getInt("zombieskilledworth");
getConfig().set("zombieskilled", zkillcount + 1);
saveConfig();
player.sendMessage(ChatColor.DARK_GREEN + "Zombie Killed! " + zkillworth + ChatColor.GOLD + "Added to your balance.");
}
}
 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args) {
Player player = (Player) sender;
if(commandLabel.equalsIgnoreCase("zombiemine")) {
player.sendMessage(ChatColor.GOLD + "" + this.getConfig().getInt("zombieskilled") + ChatColor.DARK_GREEN + " Zombies" + ChatColor.GOLD + " killed in total.");
}
return false;
}
 
}

Thing is, it's now creating the MobMine/config.yml (Which I'm so fucking happy about) however it's not updating the killcount every time I kill a zombie?

I haven't registered my events? I'm unsure what you mean by this? And when I come to check if sender instanceof player isn't that this bit?
if (sender instanceof Player && deadEntity instanceof Zombie) {

 

wh1ld you don't check instanceof in your onCommand. Also more info about events can be found here (which also explains registering events) : http://wiki.bukkit.org/Event_API_Reference