Solved Cannot figure out this NPE D:

So I have a general playerclass FcPlayers and in that class I have a getter and setter job method inside like so

Code:java

private String playerJob;

Code:java

public FcPlayers(FiddyCraft plugin, Player P){
        this.plugin = plugin;
        Player p = P;
        allPlayers = plugin.getPlayerInfo().getConfigurationSection("Players").getKeys(false);
        Name = p.getName();
        playerJob = plugin.getPlayerInfo().getString("Players." +p.getUniqueId().toString()+ ".Job");
        }

Code:java

    public String getPlayerJob(){
        return playerJob;
    }

Code:java

    public void setPlayerJob(String pJob){
        plugin.getPlayerInfo().set("Players." +p.getUniqueId().toString() + ".Job", pJob);
        plugin.savePlayerInfo();
    }

and the method I have for initially setting all this

Code:java

    public void setNewPlayer(Player p ){
        if(!this.getPlayerInfo().contains("Players.")){
            this.getPlayerInfo().set("Players", "Yo mama");
            this.savePlayerInfo();
        }
this.getPlayerInfo().set("Players." +p.getUniqueId().toString() + ".Job", "Unemployed");
this.savePlayerInfo();
}

and my playerfile looks like this

Code:

Players:
  e3e271ef-9134-30c9-b624-181e8a3e5810:
    Name: Fiddy_percent
    StartDate: 2014/07/26 11:12
    Job: Unemployed
    Arrests: 0
    Convictions: 0
    Murders: 0
    Wanted: false
    On Parol: false
    Pending Trial: false
    Can Lawyer: false
    Max Food Level: 2
    Max Crops: 16
    Max Animals: 4

yet it always comes back saying that

Code:

by: java.lang.NullPointerException
    at io.github.FiddyPercent.fiddycraft.FcPlayers.setPlayerJob(FcPlayers.java:150) ~[?:?]

line 150 being

Code:

        plugin.getPlayerInfo().set("Players." +p.getUniqueId().toString() + ".Job", pJob);

 

Fiddy_percent

Would you be able to provide the entirety of your FcPlayers.java class using pastie? It'll just save us the trouble of blindly throwing invalid answers at you.

 

You are getting a NullPonterException, this means you are trying to use something that is null in an instance where it needs an object. From the code I see pJob is initialized but has no value to it. So it's returning that value null while it doesn't want a null value. Did you mean to put playerJob there?

 

this is the what I use to set the player job

Code:java

FcPlayers fcp = new FcPlayers(plugin,p);
        fcp.setPlayerJob("Farmer");

it shouldn't be null.

yeah sure. This is also happening for another class I created and I have no clue why I keep getting nulls

http://pastebin.com/DibGJzWv

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Fiddy_percent

Well there's your error. You're not initializing your private Player p. On line 35, remove the "Player" so it reads "p = P".

 

Dragonphase
YAY that was it thank you so much

 

Fiddy_percent
Happy to help!