Solved AsyncRepeatingTask Not Working Properly, Replacement Needed.

Hello,

in my onEnable() section, I have a timer system set up that automatically logs each online player's location every configured amount of seconds. It does this in an AsyncRepeatingTask. Code:

Code:java

        this.getServer().getScheduler()
        .scheduleAsyncRepeatingTask(this, new Runnable() {
            public void run() {
                int number = getConfig().getInt("interval", 15);
                if (number != 0) {
                    number--;
                    getLogger().info("1 was subtracted from number.");
                } else {
                    // -----> Main Logger <-----\\
                    PreparedStatement log;
                    try {
                        getLogger().info("2nd try started.");
                        log = MySQL
                                .openConnection()
                                .prepareStatement(
                                        "INSERT INTO LW (`ign`, `w`, `x`, `y`, `z`) VALUES (?, ?, ?, ?, ?,);");
                        getLogger().info("2nd try finished.");
 
                        for (Player p : Bukkit.getOnlinePlayers()) {
                            Location loc = p.getLocation();
                            log.setString(1, p.getName());
                            log.setString(2, loc.getWorld().getName());
                            log.setNString(3,
                                    String.valueOf(loc.getX()));
                            log.setNString(4,
                                    String.valueOf(loc.getY()));
                            log.setNString(5,
                                    String.valueOf(loc.getZ()));
                            log.execute();
                            getLogger().info("Data logged for " + p.getName());
                        }
 
                    } catch (SQLException e) {
                        e.printStackTrace();
                    }
 
                    number = getConfig().getInt("interval");
                }
            }
        }, 0L, 20L);

As you can see, I have some loggers in place because I've been working on debugging this. I realize the whole thing is deprecated, and that's why I'm here. Even if multiple players are online, the only message that is returned to the console is this:

Code:java

getLogger().info("1 was subtracted from number.");

Every 15 seconds, as planned, it does not echo that as the number is equal to zero, but none of the other messages are returned and nothing is really logged.

Since it's deprecated, I'm not all that surprised, and I won't be if the AsyncRepeatingTask is just not a valid method of doing this. If anyone can spot any other errors I may have, please let me know. If you know of another working way to do this and can confirm that the ART I'm using will never work, please let me know below. I'm kinda new to this stuff.

Full Code: https://github.com/TacticalCactupi/LW

Thanks,
larsima/TacticalCactupi/Build_/Chris

 

Every time your task executes, this code

Code:java

int number = getConfig().getInt("interval", 15);

will always set number back to what it was.
Either have the task change the number in your config or declare the int in the class rather than the runnable.

 

Build_and_Break
Most of the methods you are using are not thread safe. You may want to wrap with immutable before accessing in async.

 

Okay, I think I get what you're saying. Wouldn't declaring it outside of the ART work just as well so it wouldn't just keep flipping between 14 and 15?

I've scrapped the old AsyncRepeatingTask and wrapped the old contents in this:

Code:java

        BukkitScheduler scheduler = Bukkit.getServer().getScheduler();
        scheduler.scheduleSyncRepeatingTask(this, new Runnable() {
            @Override
            public void run() {
                // Do something
            }
        }, 0L, 20L);

However, It appears the number doesn't reset, it just keeps running the stuff in lines 13, 14, 15, and 16. How would I reset the number to whatever is defined in the config? I guess declaring it like this doesn't work:

Code:java

number = getConfig().getInt("interval", 15);

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Build_and_Break

Code:java

number = getConfig().getInt("interval", 15);

Will always be to whatever the config says. After doing number-- or other things with the int, you can always set it back by using the above code again or by just assinging it a different number.

 

I am doing that on line 39 but it doesn't set it back...

Code:java

 BukkitScheduler scheduler = Bukkit.getServer().getScheduler();
scheduler.scheduleSyncRepeatingTask(this, new Runnable() {
int number = getConfig().getInt("interval", 15);
@Override
public void run() {
if (number != 0) {
number--;
getLogger().info("1 was subtracted from number.");
} else {
// -----> Main Logger <-----\\
PreparedStatement log;
try {
getLogger().info("2nd try started.");
log = MySQL
.openConnection()
.prepareStatement(
"INSERT INTO LW (`ign`, `w`, `x`, `y`, `z`) VALUES (?, ?, ?, ?, ?,);");
getLogger().info("2nd try finished.");
 
for (Player p : Bukkit.getOnlinePlayers()) {
Location loc = p.getLocation();
log.setString(1, p.getName());
log.setString(2, loc.getWorld().getName());
log.setNString(3,
String.valueOf(loc.getX()));
log.setNString(4,
String.valueOf(loc.getY()));
log.setNString(5,
String.valueOf(loc.getZ()));
getLogger().info("Beginning log for" + p.getName());
log.execute();
getLogger().info("Data logged for " + p.getName());
}
 
} catch (SQLException e) {
e.printStackTrace();
}
 
number = getConfig().getInt("interval", 15);
}
}
}, 0L, 20L);

teej107 ^

 

Save of the messing about and change to this

Code:java

BukkitScheduler scheduler = Bukkit.getServer().getScheduler();
        scheduler.scheduleSyncRepeatingTask(this, new Runnable() {
 
            @Override
            public void run() {
                if(Bukkit.getOnlinePlayers().length != 0) {
 
                    getLogger().info("There are players online lets start logging");
 
                    // -----> Main Logger <-----\\
                    PreparedStatement log;
                    try {
 
                        log = MySQL
                                .openConnection()
                                .prepareStatement(
                                        "INSERT INTO LW (`ign`, `w`, `x`, `y`, `z`) VALUES (?, ?, ?, ?, ?,);");
                        getLogger().info("Start looping online players");
 
                        for (Player p : Bukkit.getOnlinePlayers()) {
                            Location loc = p.getLocation();
                            log.setString(1, p.getName());
                            log.setString(2, loc.getWorld().getName());
                            log.setNString(3,
                                    String.valueOf(loc.getX()));
                            log.setNString(4,
                                    String.valueOf(loc.getY()));
                            log.setNString(5,
                                    String.valueOf(loc.getZ()));
                            getLogger().info("Beginning log for" + p.getName());
                            log.execute();
                            getLogger().info("Data logged for " + p.getName());
                        }
                        getLogger().info("Finished looping online players");
 
                    } catch (SQLException e) {
                        e.printStackTrace();
                    }
 
 
                }
                getLogger().info("Tasks ended should restart in 15 seconds");
            }
        }, 100L, 20L * getConfig().getLong("interval",15L));

Basically the task will run if there are players online, if not will wait another 15 seconds. I have also set a 5 second delay for the first task to allow the server to get fully loaded before running the first time. You also need to store the interval as a long to. Not tested it but should work for you.

 

If you never modify the number, what exactly did you expect?

Declare it inside the anonymous class instead of the method.

 

Relicum Okay, thanks. Wasn't sure if that'd work, I'll test that when I get home. Thanks!

Garris0n Look again.

Code:java

if (number != 0) {
                    number--;
                    getLogger().info("1 was subtracted from number.");
                } else {

And declaring it in the anonymous class wouldn't work. The Async I was originally using wouldn't take variables not define inside it unless the variable was something like getConfig.

 

So it is not working after you did that?

 

Don't run SQL queries in the main thread (I.e. using a sync task), if the database is remote this could cause an arbitrarily long delay due to connection issues, plus a large database could take a long time to query. That being said, using the Bukkit API from a worker thread is certianly not the best route to go either, you're going to need two threads.

 

Garris0n It didn't go back to subtracting the number after running through the 15th time. I'm using Relicum's strategy now.

SOLVED : Confirmed that @Relicum's method works. I've got a few more errors to work out before this plugin releases. Thanks guys!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.