ArrayList problems

I am making spawn protection for my kit server and the arrayLists Dont seems to be working all that well. Yes Everything is registered and I have a plugin.yml

Code:java

package Bods.Main;
 
import java.util.ArrayList;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Location;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.EntityDamageByEntityEvent;
import org.bukkit.event.entity.EntityDamageEvent;
import org.bukkit.event.entity.EntityShootBowEvent;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.event.player.PlayerMoveEvent;
 
public class SpawnProt implements Listener {
 
    ArrayList<Player> Protection = new ArrayList<Player>();
 
    public static Location Spawn = new Location(Bukkit.getWorld("World"), 0.5,
            5, 0.5);
 
    public static boolean border(Location loc) {
        return isInSpawn(loc, 11);
    }
 
    public static boolean isInSpawn(Location loc, int radius) {
        if (loc == null) {
            return false;
        }
        int x = Math.abs(loc.getBlockX() - Spawn.getBlockX());
        int z = Math.abs(loc.getBlockZ() - Spawn.getBlockZ());
        return (x < radius && z < radius);
    }
 
    @EventHandler
    public void Damage(EntityDamageEvent e) {
        if (e.getEntity() instanceof Player) {
            Player player = (Player) e.getEntity();
            if (SpawnProt.border(player.getLocation())
                    && Protection.contains(player)) {
                e.setCancelled(true);
            } else {
                e.setCancelled(false);
            }
        }
    }
 
    @EventHandler
    public void BowDamage(EntityShootBowEvent e) {
        if (e.getEntity() instanceof Player) {
            Player player = (Player) e.getEntity();
            if (SpawnProt.border(player.getLocation())
                    && Protection.contains(player)) {
                e.setCancelled(true);
            } else {
                e.setCancelled(false);
            }
        }
    }
 
    @EventHandler
    public void DamageOthers(EntityDamageByEntityEvent e) {
        if(e.getEntity() instanceof Player) {
            Player player = (Player) e.getEntity();
            if (Protection.contains(player)) {
                e.setCancelled(true);
            } else {
                if(Protection.contains(player) == false) {
                    e.setCancelled(false);
                }
            }
        }
    }
 
    @EventHandler
    public void onSpawnLeave(PlayerMoveEvent event) {
        Player player = event.getPlayer();
        Location from = event.getFrom();
        Location to = event.getTo();
        if (SpawnProt.border(from) && !SpawnProt.border(to)) {
            player.sendMessage(ChatColor.GRAY
                    + "You have lost Spawn Protection!");
            Protection.remove(player);
        }
    }
 
    @EventHandler
    public void onJoin(PlayerJoinEvent e) {
        Player player = e.getPlayer();
        Protection.add(player);
    }
 
    @EventHandler
    public void onDeath(PlayerDeathEvent e) {
        Player player = e.getEntity();
        Protection.add(player);
    }
 
}
 

 

First things first, you should never store a reference to an actual player object. This can cause some serious problems for your server. Lastly, what exactly is the problem? What is the code doing that it shouldnt be doing, and what are you expecting it to do?

 

CorrieKay I want the player to spawn at the center which I already have in another class, but In the spawn area the player has spawn prot. no player can damage the player till he leaves the spawn then the player can damage other player that have left the spawn too. Also when the player comes back in the spawn they can still be killed

 

JellyYods

Please follow the Java Naming Convention! Garris0n ;D

 

Okay, so we know what you want it to do, but what exactly is it doing wrong? Where is the problem?

Most people aren't going to want to crawl through your code looking for any and all bugs, my friend :\

 

CorrieKay The problem is People can still be attacked in spawn area